webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc - Issue 2364403004: Creating controller manager from config string in audio network adaptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

Issue 2364403004: Creating controller manager from config string in audio network adaptor. (Closed)

Patch Set: Updates Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h » ('j') | webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

index 9992e2dbd7dc93cb0872709541af81481368a9d8..ae573e6b85d392ad8e523c83fcda064be31ce9bd 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

@@ -60,7 +60,7 @@ class DebugDumpWriterImpl final : public DebugDumpWriter {

DebugDumpWriterImpl::DebugDumpWriterImpl(FILE* file_handle)

: dump_file_(FileWrapper::Create()) {

#ifndef WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP

- RTC_DCHECK(false);

+ RTC_NOTREACHED();

#endif

dump_file_->OpenFromFileHandle(file_handle);

RTC_CHECK(dump_file_->is_open());