Creating controller manager from config string in audio network adaptor.

webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 38 matching lines @@
     // packet-loss ^   |  |
     //             |   |  |   FEC
     //             |    \  \   ON
     //             | FEC \  \_______ fec_enabling_threshold
     //             | OFF  \_________ fec_disabling_threshold
     //             |-----------------> bandwidth
     Config(bool initial_fec_enabled,
            const Threshold& fec_enabling_threshold,
            const Threshold& fec_disabling_threshold,
            int time_constant_ms,
-           Clock* clock);
+           const Clock* clock);

[minyue-webrtc, 2016/09/27 14:45:18]

fixing an old error (dependent on this CL)

     bool initial_fec_enabled;
     Threshold fec_enabling_threshold;
     Threshold fec_disabling_threshold;
     int time_constant_ms;
-    Clock* clock;
+    const Clock* clock;

[hlundin-webrtc, 2016/09/27 20:21:16]

double const, right?

[minyue-webrtc, 2016/09/27 20:50:20]

not sure. since Config as a struct can allow people to overwrite fields before
commit to ctor. The controller takes whole Config as const.

[hlundin-webrtc, 2016/09/29 09:31:52]

Yes, it's a struct. Now I see.

   };
 
   explicit FecController(const Config& config);
 
   // Dependency injection for testing.
   FecController(const Config& config,
                 std::unique_ptr<SmoothingFilter> smoothing_filter);
 
   ~FecController() override;
 
@@ skipping 10 matching lines @@
 
   float GetPacketLossThreshold(int bandwidth_bps,
                                const Config::Threshold& threshold,
                                const ThresholdInfo& threshold_info) const;
 
   bool FecEnablingDecision(const NetworkMetrics& metrics) const;
   bool FecDisablingDecision(const NetworkMetrics& metrics) const;
 
   const Config config_;
   bool fec_enabled_;
   std::unique_ptr<SmoothingFilter> packet_loss_smoothed_;

[michaelt, 2016/09/27 15:51:26]

Completely unrelated to this diff.
But we should make this "const std::unique_ptr<SmoothingFilter>"

[minyue-webrtc, 2016/09/27 19:44:00]

ok. will consider in a separate CL.

 
   const ThresholdInfo fec_enabling_threshold_info_;
   const ThresholdInfo fec_disabling_threshold_info_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(FecController);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_FEC_CONTROLLER_H_