Creating controller manager from config string in audio network adaptor.

webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 27 matching lines @@
   struct Config {
     Config(int min_reordering_time_ms,
            float min_reordering_squared_distance,
            const Clock* clock);
     ~Config();
     int min_reordering_time_ms;
     float min_reordering_squared_distance;
     const Clock* clock;
   };
 
+  static std::unique_ptr<ControllerManager> Create(
+      const std::string& config_string,

[kwiberg-webrtc, 2016/09/28 08:59:22]

Is this the protobuf? In that case, isn't there a way to pass it around without
serializing it? You want the flexibility and version support of a protobuf, but
since you're not sending it outside the process, you shouldn't be encoding it, I
think. (Caveat: I know little about protobuf in particular; this is reasoning
from how I assume it probably works.)

[minyue-webrtc, 2016/09/28 12:47:26]

Serializing makes cross-platform/language possible. That is an advantage we want
to achieve here.

[kwiberg-webrtc, 2016/09/28 13:10:24]

But that argues for serialization at language and process boundaries, right? Not
anywhere else? And this isn't such a boundary?

[minyue-webrtc, 2016/09/28 16:32:34]

This is also because we want to limit the use of protobuf, which may be
unavailable. So by serializing it here, we let all middle layers carry a generic
type (string).

+      size_t num_encoder_channels,
+      const std::vector<int>& encoder_frame_lengths_ms,

[michaelt, 2016/09/27 15:51:26]

we could pass a array_view here. Since the supported frame lengths from the
encoder will be const.

[minyue-webrtc, 2016/09/27 19:43:59]

good. with do.

[hlundin-webrtc, 2016/09/27 20:21:15]

I wouldn't mind keeping this like this. It keeps us out of liftetime management
problems at a low cost.

[kwiberg-webrtc, 2016/09/28 08:59:22]

ArrayView is the right choice here; it wouldn't cause any lifetime problems.
Both ArrayView and const vector& are things the callee can read from (and copy)
but not save a pointer to or steal. The difference is that ArrayView doesn't
dictate how the caller must have allocated the array.

[minyue-webrtc, 2016/09/28 12:47:26]

Done.

+      size_t intial_channels_to_encode,
+      int initial_frame_length_ms,
+      int initial_bitrate_bps,
+      bool initial_fec_enabled,
+      bool initial_dtx_enabled,
+      const Clock* clock);
+
   explicit ControllerManagerImpl(const Config& config);
 
   // Dependency injection for testing.
   ControllerManagerImpl(
       const Config& config,
       std::vector<std::unique_ptr<Controller>>&& controllers,
       const std::map<const Controller*, std::pair<int, float>>&
           chracteristic_points);
 
   ~ControllerManagerImpl() override;
@@ skipping 31 matching lines @@
   // |scoring_points_| saves the characteristic scoring points of various
   // controllers.
   std::map<const Controller*, ScoringPoint> controller_scoring_points_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(ControllerManagerImpl);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_CONTROLLER_MANAGER_H_