Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2363423002: header_usage.sh script: Exclude matches in gyp and gn files. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

header_usage.sh script: Exclude matches in gyp and gn files. NOTRY=true BUG=None Committed: https://crrev.com/98088dccccac790f77a28cd6e1a28e9b93a97de6 Cr-Commit-Position: refs/heads/master@{#14382}

Patch Set 1 #

Patch Set 2 : Ignore all *.gn* and *.gyp* files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/tools/header_usage.sh View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
nisse-webrtc
Makes header files which are only ever mentioned in build files get a count of ...
4 years, 2 months ago (2016-09-26 09:00:56 UTC) #2
kjellander_webrtc
I think you want to include *.gni and *.gypi files as well to be sure. ...
4 years, 2 months ago (2016-09-26 09:57:25 UTC) #3
nisse-webrtc
On 2016/09/26 09:57:25, kjellander_webrtc wrote: > I think you want to include *.gni and *.gypi ...
4 years, 2 months ago (2016-09-26 10:13:13 UTC) #4
kjellander_webrtc
lgtm
4 years, 2 months ago (2016-09-26 11:48:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2363423002/20001
4 years, 2 months ago (2016-09-26 11:53:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 18:44:35 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:44:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98088dccccac790f77a28cd6e1a28e9b93a97de6
Cr-Commit-Position: refs/heads/master@{#14382}

Powered by Google App Engine
This is Rietveld 408576698