New helper function test::ReadI420Buffer, refactor FrameReader to use it.

webrtc/test/testsupport/metrics/video_metrics.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/test/testsupport/metrics/video_metrics.h"
 
 #include <assert.h>
 #include <stdio.h>
 
 #include <algorithm>  // min_element, max_element
 #include <memory>
 
 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
+#include "webrtc/test/frame_utils.h"
 #include "webrtc/video_frame.h"
 #include "libyuv/convert.h"
 
 namespace webrtc {
 namespace test {
 
 // Copy here so our callers won't need to include libyuv for this constant.
 double kMetricsPerfectPSNR = kPerfectPSNR;
 
 // Used for calculating min and max values.
@@ skipping 73 matching lines @@
   FILE* test_fp = fopen(test_filename, "rb");
   if (test_fp == NULL) {
     // Cannot open test file.
     fprintf(stderr, "Cannot open file %s\n", test_filename);
     fclose(ref_fp);
     return -2;
   }
   int frame_number = 0;
 
   // Read reference and test frames.
-  const size_t frame_length = 3 * width * height >> 1;
-  rtc::scoped_refptr<I420Buffer> ref_i420_buffer;
-  rtc::scoped_refptr<I420Buffer> test_i420_buffer;
-  std::unique_ptr<uint8_t[]> ref_buffer(new uint8_t[frame_length]);
-  std::unique_ptr<uint8_t[]> test_buffer(new uint8_t[frame_length]);
+  for (;;) {
+    rtc::scoped_refptr<I420Buffer> ref_i420_buffer(
+        test::ReadI420Buffer(width, height, ref_fp));
+    if (!ref_i420_buffer)
+      break;
 
-  // Set decoded image parameters.
-  int half_width = (width + 1) / 2;
-  ref_i420_buffer =
-      I420Buffer::Create(width, height, width, half_width, half_width);
-  test_i420_buffer =
-      I420Buffer::Create(width, height, width, half_width, half_width);
+    rtc::scoped_refptr<I420Buffer> test_i420_buffer(
+        test::ReadI420Buffer(width, height, test_fp));
 
-  // TODO(nisse): Have a frame reader in one place. And read directly
-  // into the planes of an I420Buffer, the extra copying below is silly.
-  size_t ref_bytes = fread(ref_buffer.get(), 1, frame_length, ref_fp);
-  size_t test_bytes = fread(test_buffer.get(), 1, frame_length, test_fp);
-  while (ref_bytes == frame_length && test_bytes == frame_length) {
-    // Converting from buffer to plane representation.
-    size_t size_y = width * height;
-    size_t size_uv = half_width * ((height + 1) / 2);
-    libyuv::I420Copy(
-        ref_buffer.get(), width,
-        ref_buffer.get() + size_y, half_width,
-        ref_buffer.get() + size_y + size_uv, half_width,
-        ref_i420_buffer->MutableDataY(), ref_i420_buffer->StrideY(),
-        ref_i420_buffer->MutableDataU(), ref_i420_buffer->StrideU(),
-        ref_i420_buffer->MutableDataV(), ref_i420_buffer->StrideV(),
-        width, height);
-
-    libyuv::I420Copy(
-        test_buffer.get(), width,
-        test_buffer.get() + size_y, half_width,
-        test_buffer.get() + size_y + size_uv, half_width,
-        test_i420_buffer->MutableDataY(), test_i420_buffer->StrideY(),
-        test_i420_buffer->MutableDataU(), test_i420_buffer->StrideU(),
-        test_i420_buffer->MutableDataV(), test_i420_buffer->StrideV(),
-        width, height);
+    if (!test_i420_buffer)
+      break;
 
     switch (video_metrics_type) {
       case kPSNR:
         CalculateFrame(kPSNR, *ref_i420_buffer, *test_i420_buffer, frame_number,
                        psnr_result);
         break;
       case kSSIM:
         CalculateFrame(kSSIM, *ref_i420_buffer, *test_i420_buffer, frame_number,
                        ssim_result);
         break;
       case kBoth:
         CalculateFrame(kPSNR, *ref_i420_buffer, *test_i420_buffer, frame_number,
                        psnr_result);
         CalculateFrame(kSSIM, *ref_i420_buffer, *test_i420_buffer, frame_number,
                        ssim_result);
         break;
     }
     frame_number++;
-    ref_bytes = fread(ref_buffer.get(), 1, frame_length, ref_fp);
-    test_bytes = fread(test_buffer.get(), 1, frame_length, test_fp);
   }
   int return_code = 0;
   if (frame_number == 0) {
     fprintf(stderr, "Tried to measure video metrics from empty files "
             "(reference file: %s  test file: %s)\n", ref_filename,
             test_filename);
     return_code = -3;
   } else {
     CalculateStats(psnr_result);
     CalculateStats(ssim_result);
@@ skipping 30 matching lines @@
                       int width,
                       int height,
                       QualityMetricsResult* result) {
   assert(result != NULL);
   return CalculateMetrics(kSSIM, ref_filename, test_filename, width, height,
                           NULL, result);
 }
 
 }  // namespace test
 }  // namespace webrtc