Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2362673002: Revert of Remove unnecessary interface TelephoneEventHandler (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
the sun, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove unnecessary interface TelephoneEventHandler (patchset #3 id:40001 of https://codereview.webrtc.org/2357583002/ ) Reason for revert: breaks downstream code Original issue's description: > Remove unnecessary interface TelephoneEventHandler. > > BUG=webrtc:2795 > > Committed: https://crrev.com/2beb42983ca24e1326a9a7f2c06b3ad740eea2c3 > Cr-Commit-Position: refs/heads/master@{#14346} TBR=henrik.lundin@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2795 Committed: https://crrev.com/799a9d017a807cefb62a15a38d81fe2ad16a586a Cr-Commit-Position: refs/heads/master@{#14348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 2 chunks +18 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 1 chunk +12 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
Created Revert of Remove unnecessary interface TelephoneEventHandler
4 years, 3 months ago (2016-09-22 10:36:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2362673002/1
4 years, 3 months ago (2016-09-22 10:36:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 10:36:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/799a9d017a807cefb62a15a38d81fe2ad16a586a Cr-Commit-Position: refs/heads/master@{#14348}
4 years, 3 months ago (2016-09-22 10:36:38 UTC) #6
hlundin-webrtc
4 years, 2 months ago (2016-09-26 15:17:37 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698