Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2362003002: Revert of Adding debug dump to audio network adaptor. (Closed)

Created:
4 years, 3 months ago by minyue-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding debug dump to audio network adaptor. (patchset #5 id:140001 of https://codereview.webrtc.org/2356763002/ ) Reason for revert: Chromium bot fails Original issue's description: > Adding debug dump to audio network adaptor. > > BUG=webrtc:6303 > > Committed: https://crrev.com/7e4f8928062afc8d571bb69f3223711701cbaad6 > Cr-Commit-Position: refs/heads/master@{#14361} TBR=michaelt@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6303 Committed: https://crrev.com/161b3907abd73b0d0d723d3fe51cf20edfcfd3f9 Cr-Commit-Position: refs/heads/master@{#14362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -412 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 3 chunks +0 lines, -16 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi View 2 chunks +1 line, -28 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 3 chunks +0 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 5 chunks +7 lines, -31 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 4 chunks +1 line, -76 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller.h View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/debug_dump.proto View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_debug_dump_writer.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
minyue-webrtc
Created Revert of Adding debug dump to audio network adaptor.
4 years, 3 months ago (2016-09-22 21:16:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2362003002/1
4 years, 3 months ago (2016-09-22 21:16:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 21:16:58 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:17:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/161b3907abd73b0d0d723d3fe51cf20edfcfd3f9
Cr-Commit-Position: refs/heads/master@{#14362}

Powered by Google App Engine
This is Rietveld 408576698