webrtc/video/video_stream_decoder.cc - Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_stream_decoder.cc

Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline. (Closed)

Patch Set: Add fake renderer to build files. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_stream_decoder.cc

diff --git a/webrtc/video/video_stream_decoder.cc b/webrtc/video/video_stream_decoder.cc

index 6797353161dce52cb74a8d8dac1370a7bce871c1..73633615a49908c991761d631f190133c15c9904 100644

--- a/webrtc/video/video_stream_decoder.cc

+++ b/webrtc/video/video_stream_decoder.cc

@@ -84,8 +84,8 @@ int32_t VideoStreamDecoder::FrameToRender(VideoFrame& video_frame) { // NOLINT

}

- if (incoming_video_stream_)

- incoming_video_stream_->OnFrame(video_frame);

+ RTC_DCHECK(incoming_video_stream_ != nullptr);

perkj_webrtc 2016/09/28 15:08:59 nit: you don't need this type of dchecks - it will

sakal 2016/09/29 12:00:59 Done.

+ incoming_video_stream_->OnFrame(video_frame);

return 0;

}

« no previous file with comments | « webrtc/video/video_receive_stream.cc ('k') | webrtc/video_receive_stream.h » ('j') | no next file with comments »