Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: webrtc/video_receive_stream.h

Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline. (Closed)
Patch Set: Remove the DCHECK since it will crash anyway. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 // restored to the last non-RTX packet payload type received. 155 // restored to the last non-RTX packet payload type received.
156 bool use_rtx_payload_mapping_on_restore = false; 156 bool use_rtx_payload_mapping_on_restore = false;
157 157
158 // RTP header extensions used for the received stream. 158 // RTP header extensions used for the received stream.
159 std::vector<RtpExtension> extensions; 159 std::vector<RtpExtension> extensions;
160 } rtp; 160 } rtp;
161 161
162 // Transport for outgoing packets (RTCP). 162 // Transport for outgoing packets (RTCP).
163 Transport* rtcp_send_transport = nullptr; 163 Transport* rtcp_send_transport = nullptr;
164 164
165 // VideoRenderer will be called for each decoded frame. 'nullptr' disables 165 // Must not be 'nullptr' when the stream is started.
166 // rendering of this stream.
167 rtc::VideoSinkInterface<VideoFrame>* renderer = nullptr; 166 rtc::VideoSinkInterface<VideoFrame>* renderer = nullptr;
168 167
169 // Expected delay needed by the renderer, i.e. the frame will be delivered 168 // Expected delay needed by the renderer, i.e. the frame will be delivered
170 // this many milliseconds, if possible, earlier than the ideal render time. 169 // this many milliseconds, if possible, earlier than the ideal render time.
171 // Only valid if 'renderer' is set. 170 // Only valid if 'renderer' is set.
172 int render_delay_ms = 10; 171 int render_delay_ms = 10;
173 172
174 // If set, pass frames on to the renderer as soon as they are 173 // If set, pass frames on to the renderer as soon as they are
175 // available. 174 // available.
176 bool disable_prerenderer_smoothing = false; 175 bool disable_prerenderer_smoothing = false;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 // TODO(pbos): Add info on currently-received codec to Stats. 207 // TODO(pbos): Add info on currently-received codec to Stats.
209 virtual Stats GetStats() const = 0; 208 virtual Stats GetStats() const = 0;
210 209
211 protected: 210 protected:
212 virtual ~VideoReceiveStream() {} 211 virtual ~VideoReceiveStream() {}
213 }; 212 };
214 213
215 } // namespace webrtc 214 } // namespace webrtc
216 215
217 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_ 216 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« webrtc/modules/video_coding/generic_decoder.cc ('K') | « webrtc/video/video_stream_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698