Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/video/video_receive_stream.cc

Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline. (Closed)
Patch Set: Remove the DCHECK since it will crash anyway. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 rtc::VideoSinkInterface<VideoFrame>* renderer = nullptr; 281 rtc::VideoSinkInterface<VideoFrame>* renderer = nullptr;
282 if (config_.renderer) { 282 if (config_.renderer) {
283 if (config_.disable_prerenderer_smoothing) { 283 if (config_.disable_prerenderer_smoothing) {
284 renderer = this; 284 renderer = this;
285 } else { 285 } else {
286 incoming_video_stream_.reset( 286 incoming_video_stream_.reset(
287 new IncomingVideoStream(config_.render_delay_ms, this)); 287 new IncomingVideoStream(config_.render_delay_ms, this));
288 renderer = incoming_video_stream_.get(); 288 renderer = incoming_video_stream_.get();
289 } 289 }
290 } 290 }
291 RTC_DCHECK(renderer != nullptr);
291 292
292 video_stream_decoder_.reset(new VideoStreamDecoder( 293 video_stream_decoder_.reset(new VideoStreamDecoder(
293 &video_receiver_, &rtp_stream_receiver_, &rtp_stream_receiver_, 294 &video_receiver_, &rtp_stream_receiver_, &rtp_stream_receiver_,
294 rtp_stream_receiver_.IsRetransmissionsEnabled(), 295 rtp_stream_receiver_.IsRetransmissionsEnabled(),
295 rtp_stream_receiver_.IsFecEnabled(), &stats_proxy_, renderer, 296 rtp_stream_receiver_.IsFecEnabled(), &stats_proxy_, renderer,
296 config_.pre_render_callback)); 297 config_.pre_render_callback));
297 // Register the channel to receive stats updates. 298 // Register the channel to receive stats updates.
298 call_stats_->RegisterStatsObserver(video_stream_decoder_.get()); 299 call_stats_->RegisterStatsObserver(video_stream_decoder_.get());
299 // Start the decode thread 300 // Start the decode thread
300 decode_thread_.Start(); 301 decode_thread_.Start();
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 const std::vector<uint16_t>& sequence_numbers) { 397 const std::vector<uint16_t>& sequence_numbers) {
397 rtp_stream_receiver_.RequestPacketRetransmit(sequence_numbers); 398 rtp_stream_receiver_.RequestPacketRetransmit(sequence_numbers);
398 } 399 }
399 400
400 void VideoReceiveStream::RequestKeyFrame() { 401 void VideoReceiveStream::RequestKeyFrame() {
401 rtp_stream_receiver_.RequestKeyFrame(); 402 rtp_stream_receiver_.RequestKeyFrame();
402 } 403 }
403 404
404 } // namespace internal 405 } // namespace internal
405 } // namespace webrtc 406 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698