Add logging statements to places where the frame might be dropped in WebRTC pipeline.

webrtc/modules/video_coding/generic_decoder.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
+#include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/trace_event.h"
 #include "webrtc/modules/video_coding/include/video_coding.h"
 #include "webrtc/modules/video_coding/generic_decoder.h"
 #include "webrtc/modules/video_coding/internal_defines.h"
 #include "webrtc/system_wrappers/include/clock.h"
 
 namespace webrtc {
 
 VCMDecodedFrameCallback::VCMDecodedFrameCallback(VCMTiming* timing,
@@ skipping 30 matching lines @@
                        "timestamp", decodedImage.timestamp());
   // TODO(holmer): We should improve this so that we can handle multiple
   // callbacks from one call to Decode().
   VCMFrameInformation* frameInfo;
   VCMReceiveCallback* callback;
   {
     CriticalSectionScoped cs(_critSect);
     frameInfo = _timestampMap.Pop(decodedImage.timestamp());
     callback = _receiveCallback;
   }
+  RTC_DCHECK(callback != nullptr);

[Taylor Brandstetter, 2016/09/30 21:05:57]

This DCHECK seems to be being hit by libjingle_peerconnection_android_unittest,
on a "track removal" test. Example:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%...

 
   if (frameInfo == NULL) {
     LOG(LS_WARNING) << "Too many frames backed up in the decoder, dropping "
                        "this one.";
     return WEBRTC_VIDEO_CODEC_OK;
   }
 
   const int64_t now_ms = _clock->TimeInMilliseconds();
   if (decode_time_ms < 0) {
     decode_time_ms =
         static_cast<int32_t>(now_ms - frameInfo->decodeStartTimeMs);
   }
   _timing->StopDecodeTimer(decodedImage.timestamp(), decode_time_ms, now_ms,
                            frameInfo->renderTimeMs);
 
-  if (callback != NULL) {
-    decodedImage.set_render_time_ms(frameInfo->renderTimeMs);
-    decodedImage.set_rotation(frameInfo->rotation);
-    callback->FrameToRender(decodedImage);
-  }
+  decodedImage.set_render_time_ms(frameInfo->renderTimeMs);
+  decodedImage.set_rotation(frameInfo->rotation);
+  callback->FrameToRender(decodedImage);
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 int32_t VCMDecodedFrameCallback::ReceivedDecodedReferenceFrame(
     const uint64_t pictureId) {
   CriticalSectionScoped cs(_critSect);
   if (_receiveCallback != NULL) {
     return _receiveCallback->ReceivedDecodedReferenceFrame(pictureId);
   }
   return -1;
@@ skipping 88 matching lines @@
 
 bool VCMGenericDecoder::External() const {
   return _isExternal;
 }
 
 bool VCMGenericDecoder::PrefersLateDecoding() const {
   return _decoder->PrefersLateDecoding();
 }
 
 }  // namespace webrtc