Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2361493004: Relax too strict DCHECKs while parsing rtcp reports (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relax too strict DCHECKs while parsing rtcp reports BUG=chromium:649129 Committed: https://crrev.com/f292e3151155d90ca6dd9d0a1a51b4de67c02572 Cr-Commit-Position: refs/heads/master@{#14353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
4 years, 3 months ago (2016-09-22 10:42:12 UTC) #2
brandtr
lgtm If you feel like it, you can add a comment "Double check we didn't ...
4 years, 3 months ago (2016-09-22 11:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2361493004/1
4 years, 2 months ago (2016-09-22 14:15:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 14:24:33 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 14:24:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f292e3151155d90ca6dd9d0a1a51b4de67c02572
Cr-Commit-Position: refs/heads/master@{#14353}

Powered by Google App Engine
This is Rietveld 408576698