Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2361053003:
Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." (Closed)
DescriptionReland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState."
Original commit https://codereview.webrtc.org/2256663002
was reverted by https://codereview.webrtc.org/2290963002 .
BUG=webrtc:6299
TBR=pthatcher@webrtc.org
Committed: https://crrev.com/fc9414ab513941028309d15a2baf711ef38f93a7
Cr-Commit-Position: refs/heads/master@{#14584}
Patch Set 1 #
Messages
Total messages: 26 (16 generated)
The CQ bit was checked by johan@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit was reverted by https://codereview.webrtc.org/2290963002 https://codereview.webrtc.org/2256663002/ BUG=webrtc:6299 ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002/ was reverted by https://codereview.webrtc.org/2290963002 BUG=webrtc:6299 ==========
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002/ was reverted by https://codereview.webrtc.org/2290963002 BUG=webrtc:6299 ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 ==========
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/11554)
johan@webrtc.org changed reviewers: + pthatcher@webrtc.org
pthatcher@chromium.org changed reviewers: + pthatcher@chromium.org
lgtm
The CQ bit was checked by johan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9012)
On 2016/10/06 07:48:56, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9012) pthatcher@webrtc.org ptal with your @webrtc.org login. Thank you!
johan@webrtc.org changed reviewers: - pthatcher@chromium.org
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 TBR=pthatcher@webrtc.org ==========
The CQ bit was checked by johan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 TBR=pthatcher@webrtc.org ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 TBR=pthatcher@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 TBR=pthatcher@webrtc.org ========== to ========== Reland of "Remove the obsolete enum webrtc::PeerConnectionInterface::IceState." Original commit https://codereview.webrtc.org/2256663002 was reverted by https://codereview.webrtc.org/2290963002 . BUG=webrtc:6299 TBR=pthatcher@webrtc.org Committed: https://crrev.com/fc9414ab513941028309d15a2baf711ef38f93a7 Cr-Commit-Position: refs/heads/master@{#14584} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fc9414ab513941028309d15a2baf711ef38f93a7 Cr-Commit-Position: refs/heads/master@{#14584}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2402993002/ by sprang@webrtc.org. The reason for reverting is: Breaks upstream code.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
