Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 2360853003: Add tools/determinism to setup_links. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tools/determinism to setup_links. BUG=chromium:583318 NOTRY=True Committed: https://crrev.com/a78213e4d563bfe01221f9d4df94915ebf1f6a0f Cr-Commit-Position: refs/heads/master@{#14360}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments. #

Total comments: 1

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M setup_links.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-22 11:25:53 UTC) #2
kjellander_webrtc
I added NOTRY=True for you... https://codereview.webrtc.org/2360853003/diff/1/setup_links.py File setup_links.py (right): https://codereview.webrtc.org/2360853003/diff/1/setup_links.py#newcode119 setup_links.py:119: 'tools/determinism', Please add it ...
4 years, 3 months ago (2016-09-22 11:32:05 UTC) #4
kjellander_webrtc
On 2016/09/22 11:32:05, kjellander_webrtc wrote: > I added NOTRY=True for you... > > https://codereview.webrtc.org/2360853003/diff/1/setup_links.py > ...
4 years, 3 months ago (2016-09-22 11:32:25 UTC) #5
ehmaldonado_webrtc
On 2016/09/22 11:32:25, kjellander_webrtc wrote: > On 2016/09/22 11:32:05, kjellander_webrtc wrote: > > I added ...
4 years, 3 months ago (2016-09-22 11:41:31 UTC) #7
kjellander_webrtc
lgtm with nit addressed https://codereview.webrtc.org/2360853003/diff/20001/.gitignore File .gitignore (right): https://codereview.webrtc.org/2360853003/diff/20001/.gitignore#newcode150 .gitignore:150: /tools/determinism nit: sort after clang.
4 years, 3 months ago (2016-09-22 12:37:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2360853003/40001
4 years, 3 months ago (2016-09-22 17:44:27 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 17:46:19 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 17:46:24 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a78213e4d563bfe01221f9d4df94915ebf1f6a0f
Cr-Commit-Position: refs/heads/master@{#14360}

Powered by Google App Engine
This is Rietveld 408576698