Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2360583002: Adds output audio volume to iOS logs (Closed)

Created:
4 years, 3 months ago by henrika_webrtc
Modified:
4 years, 3 months ago
Reviewers:
tkchin_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds output audio volume to iOS logs BUG=b/30944297 NOTRY=TRUE Committed: https://crrev.com/c5aea65b769993a60d67952e2ea9da372a93782c Cr-Commit-Position: refs/heads/master@{#14334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
henrika_webrtc
Example output: 004:494] [35103] (RTCLogging.mm:31): (audio_device_ios.mm:733 UpdateAudioUnit): RTCAudioSession: { category: AVAudioSessionCategoryPlayAndRecord categoryOptions: 12 mode: AVAudioSessionModeVoiceChat ...
4 years, 3 months ago (2016-09-21 13:44:39 UTC) #3
henrika_webrtc
PTAL
4 years, 3 months ago (2016-09-21 13:44:51 UTC) #4
Chuck
lgtm
4 years, 3 months ago (2016-09-21 13:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2360583002/1
4 years, 3 months ago (2016-09-21 14:33:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 14:45:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:46:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5aea65b769993a60d67952e2ea9da372a93782c
Cr-Commit-Position: refs/heads/master@{#14334}

Powered by Google App Engine
This is Rietveld 408576698