Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2360053003: Fixig issues in bwe plot dynamics. (Closed)

Created:
4 years, 3 months ago by Gaetano Carlucci
Modified:
4 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixig issues in BWE dynamics plot scripts. BUG=None Committed: https://crrev.com/61050f67efbf3e3df2c6aa353db0d027be3eac4f Cr-Commit-Position: refs/heads/master@{#14459}

Patch Set 1 #

Patch Set 2 : adding overuse logs to plot_dynamics #

Total comments: 2

Patch Set 3 : removing not useful check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -39 lines) Patch
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 2 chunks +5 lines, -8 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 1 chunk +6 lines, -10 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
Gaetano Carlucci
This should fix the minor issues introduces with this https://codereview.chromium.org/2296253002/
4 years, 3 months ago (2016-09-22 08:45:56 UTC) #2
stefan-webrtc
lgtm
4 years, 2 months ago (2016-09-22 10:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2360053003/1
4 years, 2 months ago (2016-09-22 19:04:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8643)
4 years, 2 months ago (2016-09-22 19:18:47 UTC) #7
Gaetano Carlucci
now gamma and offset dynamics can be seen with plt_dynamics.sh along with packets loss, delay ...
4 years, 2 months ago (2016-09-23 12:48:03 UTC) #8
stefan-webrtc
https://codereview.chromium.org/2360053003/diff/20001/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right): https://codereview.chromium.org/2360053003/diff/20001/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py#newcode53 webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:53: return Is this still needed?
4 years, 2 months ago (2016-09-23 13:49:41 UTC) #9
Gaetano Carlucci
I will remove that check https://codereview.chromium.org/2360053003/diff/20001/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right): https://codereview.chromium.org/2360053003/diff/20001/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py#newcode53 webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:53: return On 2016/09/23 13:49:41, ...
4 years, 2 months ago (2016-09-23 14:05:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2360053003/40001
4 years, 2 months ago (2016-09-30 11:01:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8833)
4 years, 2 months ago (2016-09-30 11:27:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2360053003/40001
4 years, 2 months ago (2016-09-30 11:29:58 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 13:29:57 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:30:02 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61050f67efbf3e3df2c6aa353db0d027be3eac4f
Cr-Commit-Position: refs/heads/master@{#14459}

Powered by Google App Engine
This is Rietveld 408576698