|
|
Created:
4 years, 3 months ago by kthelgason Modified:
4 years, 3 months ago Reviewers:
kjellander_webrtc, henrika_webrtc CC:
webrtc-reviews_webrtc.org Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd custom info.plist to modules_unittests
This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it.
BUG=webrtc:6403
Committed: https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0
Cr-Commit-Position: refs/heads/master@{#14354}
Patch Set 1 #
Total comments: 3
Patch Set 2 : trim some XML bloat #
Created: 4 years, 3 months ago
Messages
Total messages: 17 (5 generated)
kthelgason@webrtc.org changed reviewers: + henrika@webrtc.org, kjellander@webrtc.org
Description was changed from ========== Add custom info.plist to modules_unittests BUG=webrtc:6403 ========== to ========== Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 ==========
https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist File webrtc/test/ios/Info.plist (right): https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne... webrtc/test/ios/Info.plist:192: <string>For testing purposes</string> This is really the only relevant line here
Works for me. Thanks! Seems like there are some other issue in one of my tests but I can deal with that once this one has landed. LGTM https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist File webrtc/test/ios/Info.plist (right): https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne... webrtc/test/ios/Info.plist:192: <string>For testing purposes</string> On 2016/09/22 13:17:15, kthelgason wrote: > This is really the only relevant line here Acknowledged.
https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist File webrtc/test/ios/Info.plist (right): https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne... webrtc/test/ios/Info.plist:192: <string>For testing purposes</string> On 2016/09/22 13:17:15, kthelgason wrote: > This is really the only relevant line here Can we strip down the Info.plist file to only contain the relevant information? 194 lines is quite long...
On 2016/09/22 13:38:59, kjellander_webrtc wrote: > Can we strip down the Info.plist file to only contain the relevant information? > 194 lines is quite long... I just copied the one that's being included by default in all test targets. There are probably some irrelevant keys in there that we can get rid of.
New and improved: Now with less XML!
LGTM++
On 2016/09/22 13:42:51, kthelgason wrote: > On 2016/09/22 13:38:59, kjellander_webrtc wrote: > > Can we strip down the Info.plist file to only contain the relevant > information? > > 194 lines is quite long... > > I just copied the one that's being included by default in all test targets. > There are probably some irrelevant keys in there that we can get rid of. Do you mean there's another copy we can trim too? LGTM either way
On 2016/09/22 14:04:52, kjellander_webrtc wrote: > Do you mean there's another copy we can trim too? There is another copy in Chromium, but I suspect they want some of the keys I removed!
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 ========== to ========== Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 ========== to ========== Add custom info.plist to modules_unittests This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it. BUG=webrtc:6403 Committed: https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0 Cr-Commit-Position: refs/heads/master@{#14354} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0 Cr-Commit-Position: refs/heads/master@{#14354} |