Add custom info.plist to modules_unittests

Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that access the microphone have to include a string in the Info.plist file explaining why they need it.

BUG=webrtc:6403
Committed: https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0
Cr-Commit-Position: refs/heads/master@{#14354}

[kthelgason, 2016-09-22 13:16:08]

kthelgason@webrtc.org changed reviewers:
+ henrika@webrtc.org, kjellander@webrtc.org

[kthelgason, 2016-09-22 13:16:50]

Description was changed from

==========
Add custom info.plist to modules_unittests

BUG=webrtc:6403
==========

to

==========
Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that
access the microphone have to include a string in the Info.plist file explaining
why they need it.

BUG=webrtc:6403
==========

[kthelgason, 2016-09-22 13:17:15]

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist
File webrtc/test/ios/Info.plist (right):

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne...
webrtc/test/ios/Info.plist:192: <string>For testing purposes</string>
This is really the only relevant line here

[henrika_webrtc, 2016-09-22 13:26:49]

Works for me. Thanks!

Seems like there are some other issue in one of my tests but I can deal with
that once this one has landed.

LGTM

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist
File webrtc/test/ios/Info.plist (right):

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne...
webrtc/test/ios/Info.plist:192: <string>For testing purposes</string>
On 2016/09/22 13:17:15, kthelgason wrote:
> This is really the only relevant line here

Acknowledged.

[kjellander_webrtc, 2016-09-22 13:38:59]

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist
File webrtc/test/ios/Info.plist (right):

https://codereview.webrtc.org/2359863003/diff/1/webrtc/test/ios/Info.plist#ne...
webrtc/test/ios/Info.plist:192: <string>For testing purposes</string>
On 2016/09/22 13:17:15, kthelgason wrote:
> This is really the only relevant line here

Can we strip down the Info.plist file to only contain the relevant information?
194 lines is quite long...

[kthelgason, 2016-09-22 13:42:51]

On 2016/09/22 13:38:59, kjellander_webrtc wrote:
> Can we strip down the Info.plist file to only contain the relevant
information?
> 194 lines is quite long...

I just copied the one that's being included by default in all test targets.
There are probably some irrelevant keys in there that we can get rid of.

[kthelgason, 2016-09-22 13:51:47]

New and improved: Now with less XML!

[henrika_webrtc, 2016-09-22 13:52:42]

LGTM++

[kjellander_webrtc, 2016-09-22 14:04:52]

On 2016/09/22 13:42:51, kthelgason wrote:
> On 2016/09/22 13:38:59, kjellander_webrtc wrote:
> > Can we strip down the Info.plist file to only contain the relevant
> information?
> > 194 lines is quite long...
> 
> I just copied the one that's being included by default in all test targets.
> There are probably some irrelevant keys in there that we can get rid of.

Do you mean there's another copy we can trim too?

LGTM either way

[kthelgason, 2016-09-22 14:18:24]

On 2016/09/22 14:04:52, kjellander_webrtc wrote:
> Do you mean there's another copy we can trim too?

There is another copy in Chromium, but I suspect they want some of the keys I
removed!

[kthelgason, 2016-09-22 14:18:31]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2016-09-22 14:18:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-22 15:00:55]

Description was changed from

==========
Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that
access the microphone have to include a string in the Info.plist file explaining
why they need it.

BUG=webrtc:6403
==========

to

==========
Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that
access the microphone have to include a string in the Info.plist file explaining
why they need it.

BUG=webrtc:6403
==========

[commit-bot: I haz the power, 2016-09-22 15:00:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 15:01:02]

Description was changed from

==========
Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that
access the microphone have to include a string in the Info.plist file explaining
why they need it.

BUG=webrtc:6403
==========

to

==========
Add custom info.plist to modules_unittests

This is to fix an issue introduced with iOS 10 where all applications that
access the microphone have to include a string in the Info.plist file explaining
why they need it.

BUG=webrtc:6403

Committed: https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0
Cr-Commit-Position: refs/heads/master@{#14354}
==========

[commit-bot: I haz the power, 2016-09-22 15:01:03]

Patchset 2 (id:??) landed as
https://crrev.com/c37e9835a7694a2adf1916c05e54f0661cc962d0
Cr-Commit-Position: refs/heads/master@{#14354}