Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2359763002: Moved legacy_encoded_audio_frame into audio_decoder_interface. (Closed)

Created:
4 years, 3 months ago by ossu
Modified:
4 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved legacy_encoded_audio_frame into audio_decoder_interface. audio_decoder.cc depends on LegacyEncodedAudioFrame and LegacyEncodedAudioFrame depends on AudioDecoder::EncodedAudioFrame, so there's no clear way to separate them as of now. This error is also hodling up builds downstream. I expect we'll revisit these dependencies as part of the upcoming larger restructuring effort. NOTRY=true BUG=webrtc:5805 Committed: https://crrev.com/7f40ba4414024ad9bef01f16c0c5cf3bbc62a72d Cr-Commit-Position: refs/heads/master@{#14329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 4 chunks +2 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/interfaces.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ossu
Please have a look at this change. Should clear up some build issues downstream.
4 years, 3 months ago (2016-09-21 12:27:29 UTC) #3
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-09-21 12:31:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2359763002/1
4 years, 3 months ago (2016-09-21 12:38:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 12:50:40 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 12:50:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f40ba4414024ad9bef01f16c0c5cf3bbc62a72d
Cr-Commit-Position: refs/heads/master@{#14329}

Powered by Google App Engine
This is Rietveld 408576698