Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/base/proxydetect.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: manual changes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/rtpsenderreceiver_unittest.cc ('K') | « webrtc/base/platform_thread_unittest.cc ('k') | webrtc/base/random_unittest.cc » ('j') | webrtc/base/sequenced_task_checker_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/proxydetect.cc
diff --git a/webrtc/base/proxydetect.cc b/webrtc/base/proxydetect.cc
index 71910aa2d4dea77aff2756675afbfef1a1f36d9a..b400af8fcdce2b682887f19f3f233e606582f7c3 100644
--- a/webrtc/base/proxydetect.cc
+++ b/webrtc/base/proxydetect.cc
@@ -43,6 +43,11 @@
#define _TRY_JSPROXY 0
#define _TRY_WM_FINDPROXY 0
#define _TRY_IE_LAN_SETTINGS 1
+#else
+#define _TRY_WINHTTP 0
+#define _TRY_JSPROXY 0
kjellander_webrtc 2016/09/23 12:32:36 _TRY_JSPROXY 1 ?
kwiberg-webrtc 2016/09/26 08:34:30 It used to default to 0 (unless someone was settin
kjellander_webrtc 2016/09/26 08:38:14 OK, but then you can move them outside the #if def
kwiberg-webrtc 2016/09/26 08:48:52 Sure.
+#define _TRY_WM_FINDPROXY 0
kjellander_webrtc 2016/09/23 12:32:36 _TRY_WM_FINDPROXY 1 ?
kwiberg-webrtc 2016/09/26 08:34:30 Same.
+#define _TRY_IE_LAN_SETTINGS 0
#endif // WEBRTC_WIN
// For all platforms try Firefox.
« webrtc/api/rtpsenderreceiver_unittest.cc ('K') | « webrtc/base/platform_thread_unittest.cc ('k') | webrtc/base/random_unittest.cc » ('j') | webrtc/base/sequenced_task_checker_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698