webrtc/test/testsupport/metrics/video_metrics_unittest.cc - Issue 2358993004: Enable the -Wundef warning for clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/test/testsupport/metrics/video_metrics_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/test/testsupport/frame_writer_unittest.cc ('k') | webrtc/test/testsupport/mock/mock_frame_reader.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #include "webrtc/test/testsupport/metrics/video_metrics.h"	11 #include "webrtc/test/testsupport/metrics/video_metrics.h"

12	12

13 #include "testing/gtest/include/gtest/gtest.h"	13 #include "webrtc/test/gtest.h"

14 #include "webrtc/test/testsupport/fileutils.h"	14 #include "webrtc/test/testsupport/fileutils.h"

15	15

16 namespace webrtc {	16 namespace webrtc {

17	17

18 static const int kWidth = 352;	18 static const int kWidth = 352;

19 static const int kHeight = 288;	19 static const int kHeight = 288;

20	20

21 static const int kMissingReferenceFileReturnCode = -1;	21 static const int kMissingReferenceFileReturnCode = -1;

22 static const int kMissingTestFileReturnCode = -2;	22 static const int kMissingTestFileReturnCode = -2;

23 static const int kEmptyFileReturnCode = -3;	23 static const int kEmptyFileReturnCode = -3;

(...skipping 114 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138 I420MetricsFromFiles(empty_file_.c_str(), video_file_.c_str(),	138 I420MetricsFromFiles(empty_file_.c_str(), video_file_.c_str(),

139 kWidth, kHeight,	139 kWidth, kHeight,

140 &psnr_result_, &ssim_result_));	140 &psnr_result_, &ssim_result_));

141 EXPECT_EQ(kEmptyFileReturnCode,	141 EXPECT_EQ(kEmptyFileReturnCode,

142 I420MetricsFromFiles(video_file_.c_str(), empty_file_.c_str(),	142 I420MetricsFromFiles(video_file_.c_str(), empty_file_.c_str(),

143 kWidth, kHeight,	143 kWidth, kHeight,

144 &psnr_result_, &ssim_result_));	144 &psnr_result_, &ssim_result_));

145 }	145 }

146	146

147 } // namespace webrtc	147 } // namespace webrtc

OLD	NEW