Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: webrtc/system_wrappers/source/metrics_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "webrtc/test/gtest.h"
12 12
13 #include "webrtc/system_wrappers/include/metrics.h" 13 #include "webrtc/system_wrappers/include/metrics.h"
14 #include "webrtc/system_wrappers/include/metrics_default.h" 14 #include "webrtc/system_wrappers/include/metrics_default.h"
15 15
16 namespace webrtc { 16 namespace webrtc {
17 namespace { 17 namespace {
18 const int kSample = 22; 18 const int kSample = 22;
19 19
20 void AddSparseSample(const std::string& name, int sample) { 20 void AddSparseSample(const std::string& name, int sample) {
21 RTC_HISTOGRAM_COUNTS_SPARSE_100(name, sample); 21 RTC_HISTOGRAM_COUNTS_SPARSE_100(name, sample);
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 } 111 }
112 112
113 #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) 113 #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
114 TEST_F(MetricsTest, RtcHistogram_FailsForNonConstantName) { 114 TEST_F(MetricsTest, RtcHistogram_FailsForNonConstantName) {
115 AddSample("ConstantName1", kSample); 115 AddSample("ConstantName1", kSample);
116 EXPECT_DEATH(AddSample("NotConstantName1", kSample), ""); 116 EXPECT_DEATH(AddSample("NotConstantName1", kSample), "");
117 } 117 }
118 #endif 118 #endif
119 119
120 } // namespace webrtc 120 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/system_wrappers/source/metrics_default_unittest.cc ('k') | webrtc/system_wrappers/source/ntp_time_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698