Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Side by Side Diff: webrtc/system_wrappers/source/logging_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/system_wrappers/include/logging.h" 11 #include "webrtc/system_wrappers/include/logging.h"
12 12
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "webrtc/test/gtest.h"
14 #include "webrtc/base/arraysize.h" 14 #include "webrtc/base/arraysize.h"
15 #include "webrtc/base/event.h" 15 #include "webrtc/base/event.h"
16 #include "webrtc/system_wrappers/include/trace.h" 16 #include "webrtc/system_wrappers/include/trace.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 namespace { 19 namespace {
20 const char kTestLogString[] = "Incredibly important test message!(?)"; 20 const char kTestLogString[] = "Incredibly important test message!(?)";
21 const int kTestLevel = kTraceWarning; 21 const int kTestLevel = kTraceWarning;
22 22
23 class LoggingTestCallback : public TraceCallback { 23 class LoggingTestCallback : public TraceCallback {
(...skipping 24 matching lines...) Expand all
48 LoggingTestCallback callback(&event); 48 LoggingTestCallback callback(&event);
49 Trace::SetTraceCallback(&callback); 49 Trace::SetTraceCallback(&callback);
50 50
51 LOG(LS_WARNING) << kTestLogString; 51 LOG(LS_WARNING) << kTestLogString;
52 EXPECT_TRUE(event.Wait(2000)); 52 EXPECT_TRUE(event.Wait(2000));
53 53
54 Trace::SetTraceCallback(nullptr); 54 Trace::SetTraceCallback(nullptr);
55 Trace::ReturnTrace(); 55 Trace::ReturnTrace();
56 } 56 }
57 } // namespace webrtc 57 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/system_wrappers/source/event_timer_posix_unittest.cc ('k') | webrtc/system_wrappers/source/metrics_default_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698