webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc - Issue 2358993004: Enable the -Wundef warning for clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc ('k') | webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #include <memory>	11 #include <memory>

12	12

13 #include "testing/gtest/include/gtest/gtest.h"	13 #include "webrtc/test/gtest.h"

14 #include "webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h"	14 #include "webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h"

15	15

16 namespace webrtc {	16 namespace webrtc {

17	17

18 TEST(AudioDecoderFactoryTest, CreateUnknownDecoder) {	18 TEST(AudioDecoderFactoryTest, CreateUnknownDecoder) {

19 rtc::scoped_refptr<AudioDecoderFactory> adf =	19 rtc::scoped_refptr<AudioDecoderFactory> adf =

20 CreateBuiltinAudioDecoderFactory();	20 CreateBuiltinAudioDecoderFactory();

21 ASSERT_TRUE(adf);	21 ASSERT_TRUE(adf);

22 EXPECT_FALSE(adf->MakeAudioDecoder(SdpAudioFormat("rey", 8000, 1)));	22 EXPECT_FALSE(adf->MakeAudioDecoder(SdpAudioFormat("rey", 8000, 1)));

23 }	23 }

(...skipping 101 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
125 bool good =	125 bool good =

126 (hz == 48000 && channels == 2 && (stereo == "0" \|\| stereo == "1"));	126 (hz == 48000 && channels == 2 && (stereo == "0" \|\| stereo == "1"));

127 EXPECT_EQ(good, static_cast<bool>(adf->MakeAudioDecoder(SdpAudioFormat(	127 EXPECT_EQ(good, static_cast<bool>(adf->MakeAudioDecoder(SdpAudioFormat(

128 "opus", hz, channels, std::move(params)))));	128 "opus", hz, channels, std::move(params)))));

129 }	129 }

130 }	130 }

131 }	131 }

132 }	132 }

133	133

134 } // namespace webrtc	134 } // namespace webrtc

OLD	NEW