webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc - Issue 2358993004: Enable the -Wundef warning for clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #include <memory>	11 #include <memory>

12	12

13 #include "testing/gtest/include/gtest/gtest.h"	13 #include "webrtc/test/gtest.h"

14 #include "webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller.h"	14 #include "webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller.h"

15	15

16 namespace webrtc {	16 namespace webrtc {

17	17

18 namespace {	18 namespace {

19	19

20 constexpr int kDtxEnablingBandwidthBps = 55000;	20 constexpr int kDtxEnablingBandwidthBps = 55000;

21 constexpr int kDtxDisablingBandwidthBps = 65000;	21 constexpr int kDtxDisablingBandwidthBps = 65000;

22 constexpr int kMediumBandwidthBps =	22 constexpr int kMediumBandwidthBps =

23 (kDtxEnablingBandwidthBps + kDtxDisablingBandwidthBps) / 2;	23 (kDtxEnablingBandwidthBps + kDtxDisablingBandwidthBps) / 2;

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 false);	77 false);

78 CheckDecision(controller.get(), rtc::Optional<int>(kDtxEnablingBandwidthBps),	78 CheckDecision(controller.get(), rtc::Optional<int>(kDtxEnablingBandwidthBps),

79 true);	79 true);

80 CheckDecision(controller.get(), rtc::Optional<int>(kMediumBandwidthBps),	80 CheckDecision(controller.get(), rtc::Optional<int>(kMediumBandwidthBps),

81 true);	81 true);

82 CheckDecision(controller.get(), rtc::Optional<int>(kDtxDisablingBandwidthBps),	82 CheckDecision(controller.get(), rtc::Optional<int>(kDtxDisablingBandwidthBps),

83 false);	83 false);

84 }	84 }

85	85

86 } // namespace webrtc	86 } // namespace webrtc

OLD	NEW