Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webrtc/base/platform_thread_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/pathutils.cc ('k') | webrtc/base/proxydetect.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/platform_thread.h" 11 #include "webrtc/base/platform_thread.h"
12 12
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "webrtc/test/gtest.h"
14 #include "webrtc/system_wrappers/include/sleep.h" 14 #include "webrtc/system_wrappers/include/sleep.h"
15 15
16 namespace rtc { 16 namespace rtc {
17 namespace { 17 namespace {
18 // Function that does nothing, and reports success. 18 // Function that does nothing, and reports success.
19 bool NullRunFunction(void* obj) { 19 bool NullRunFunction(void* obj) {
20 webrtc::SleepMs(0); // Hand over timeslice, prevents busy looping. 20 webrtc::SleepMs(0); // Hand over timeslice, prevents busy looping.
21 return true; 21 return true;
22 } 22 }
23 23
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled"); 56 PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled");
57 thread.Start(); 57 thread.Start();
58 58
59 // At this point, the flag may be either true or false. 59 // At this point, the flag may be either true or false.
60 thread.Stop(); 60 thread.Stop();
61 61
62 // We expect the thread to have run at least once. 62 // We expect the thread to have run at least once.
63 EXPECT_TRUE(flag); 63 EXPECT_TRUE(flag);
64 } 64 }
65 } // rtc 65 } // rtc
OLDNEW
« no previous file with comments | « webrtc/base/pathutils.cc ('k') | webrtc/base/proxydetect.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698