Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: webrtc/base/httpclient.h

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/gunit.h ('k') | webrtc/base/httpcommon.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 ////////////////////////////////////////////////////////////////////// 44 //////////////////////////////////////////////////////////////////////
45 45
46 class DiskCache; 46 class DiskCache;
47 class HttpClient; 47 class HttpClient;
48 class IPNetPool; 48 class IPNetPool;
49 49
50 class SignalThread; 50 class SignalThread;
51 // What to do: Define STRICT_HTTP_ERROR=1 in your makefile. Use HttpError in 51 // What to do: Define STRICT_HTTP_ERROR=1 in your makefile. Use HttpError in
52 // your code (HttpErrorType should only be used for code that is shared 52 // your code (HttpErrorType should only be used for code that is shared
53 // with groups which have not yet migrated). 53 // with groups which have not yet migrated).
54 #if STRICT_HTTP_ERROR 54 #if defined(STRICT_HTTP_ERROR) && STRICT_HTTP_ERROR
55 typedef HttpError HttpErrorType; 55 typedef HttpError HttpErrorType;
56 #else // !STRICT_HTTP_ERROR 56 #else // !STRICT_HTTP_ERROR
57 typedef int HttpErrorType; 57 typedef int HttpErrorType;
58 #endif // !STRICT_HTTP_ERROR 58 #endif // !STRICT_HTTP_ERROR
59 59
60 class HttpClient : private IHttpNotify, public sigslot::has_slots<> { 60 class HttpClient : private IHttpNotify, public sigslot::has_slots<> {
61 public: 61 public:
62 // If HttpRequestData and HttpResponseData objects are provided, they must 62 // If HttpRequestData and HttpResponseData objects are provided, they must
63 // be freed by the caller. Otherwise, an internal object is allocated. 63 // be freed by the caller. Otherwise, an internal object is allocated.
64 HttpClient(const std::string& agent, StreamPool* pool, 64 HttpClient(const std::string& agent, StreamPool* pool,
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 public: 187 public:
188 HttpClientDefault(SocketFactory* factory, const std::string& agent, 188 HttpClientDefault(SocketFactory* factory, const std::string& agent,
189 HttpTransaction* transaction = NULL); 189 HttpTransaction* transaction = NULL);
190 }; 190 };
191 191
192 ////////////////////////////////////////////////////////////////////// 192 //////////////////////////////////////////////////////////////////////
193 193
194 } // namespace rtc 194 } // namespace rtc
195 195
196 #endif // WEBRTC_BASE_HTTPCLIENT_H__ 196 #endif // WEBRTC_BASE_HTTPCLIENT_H__
OLDNEW
« no previous file with comments | « webrtc/base/gunit.h ('k') | webrtc/base/httpcommon.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698