webrtc/common_audio/resampler/push_resampler_unittest.cc - Issue 2358993004: Enable the -Wundef warning for clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/common_audio/resampler/push_resampler_unittest.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)

Patch Set: manual changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/common_audio/blocker_unittest.cc ('K') | « webrtc/common_audio/real_fourier_unittest.cc ('k') | webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc » ('j') | webrtc/common_audio/resampler/resampler_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #include "testing/gtest/include/gtest/gtest.h"	11 #include "webrtc/base/gtest.h"
	kjellander_webrtc 2016/09/23 12:32:37 sort sort
12 #include "webrtc/base/checks.h" // force defintion of RTC_DCHECK_IS_ON	12 #include "webrtc/base/checks.h" // force defintion of RTC_DCHECK_IS_ON

13 #include "webrtc/common_audio/resampler/include/push_resampler.h"	13 #include "webrtc/common_audio/resampler/include/push_resampler.h"

14	14

15 // Quality testing of PushResampler is handled through output_mixer_unittest.cc.	15 // Quality testing of PushResampler is handled through output_mixer_unittest.cc.

16	16

17 namespace webrtc {	17 namespace webrtc {

18	18

19 // The below tests are temporarily disabled on WEBRTC_WIN due to problems	19 // The below tests are temporarily disabled on WEBRTC_WIN due to problems

20 // with clang debug builds.	20 // with clang debug builds.

21 // TODO(tommi): Re-enable when we've figured out what the problem is.	21 // TODO(tommi): Re-enable when we've figured out what the problem is.

(...skipping 24 matching lines...) Expand all Loading...
46 }	46 }

47	47

48 TEST(PushResamplerTest, VerifiesBadInputParameters4) {	48 TEST(PushResamplerTest, VerifiesBadInputParameters4) {

49 PushResampler<int16_t> resampler;	49 PushResampler<int16_t> resampler;

50 EXPECT_DEATH(resampler.InitializeIfNeeded(16000, 16000, 3), "num_channels");	50 EXPECT_DEATH(resampler.InitializeIfNeeded(16000, 16000, 3), "num_channels");

51 }	51 }

52 #endif	52 #endif

53 #endif	53 #endif

54	54

55 } // namespace webrtc	55 } // namespace webrtc

OLD	NEW