Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2357893002: Reland of Release camera statistics after switching camera on CameraCapturer. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of lease camera statistics after switching camera on CameraCapturer. (patchset #1 id:1 of https://codereview.webrtc.org/2353163003/ ) Reason for revert: Fix bugs causing the new code to fail. Original issue's description: > Revert of Release camera statistics after switching camera on CameraCapturer. (patchset #1 id:1 of https://codereview.webrtc.org/2353263002/ ) > > Reason for revert: > Breaks bots. > > Original issue's description: > > Release camera statistics after switching camera on CameraCapturer. > > > > BUG=webrtc:6397 > > TBR=magjed@webrtc.org > > NOTRY=True > > > > Committed: https://crrev.com/d5e9237b303e5fe253dc6530fbcf939921f4eaed > > Cr-Commit-Position: refs/heads/master@{#14323} > > TBR=magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6397 > > Committed: https://crrev.com/ad5d65845f5c859d0564811a4eea68e1efdb8450 > Cr-Commit-Position: refs/heads/master@{#14324} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6397 Committed: https://crrev.com/0cb8828bcec98d61c43f58e06dfa0f0dcb1eaf34 Cr-Commit-Position: refs/heads/master@{#14330}

Patch Set 1 #

Patch Set 2 : Create camera statistics before calling any callbacks and don't set switch as pending on stopped ca… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
sakal
Created Reland of lease camera statistics after switching camera on CameraCapturer.
4 years, 3 months ago (2016-09-21 11:30:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357893002/40001
4 years, 3 months ago (2016-09-21 13:08:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-21 13:08:55 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:09:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0cb8828bcec98d61c43f58e06dfa0f0dcb1eaf34
Cr-Commit-Position: refs/heads/master@{#14330}

Powered by Google App Engine
This is Rietveld 408576698