Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by aleloi Modified:
4 years, 2 months ago Reviewers:
hlundin-webrtc, phoglund CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDuring a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger.
This change trims the potentially longer array to the size of the smaller one.
NOTRY=True
BUG=none
Committed: https://crrev.com/553024ab34e7307046388d20c29e9f9a8177aa0a
Cr-Commit-Position: refs/heads/master@{#14657}
Patch Set 1 : this is the quick fix #
Created: 4 years, 3 months ago
Messages
Total messages: 17 (10 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Should be a quick fix of plot issue. BUG= ========== to ========== A quick fix of an plotting issue with the rtp analyzer. BUG=none ==========
Description was changed from ========== A quick fix of an plotting issue with the rtp analyzer. BUG=none ========== to ========== A quick fix of a pyplot plotting issue in rtp analyzer. BUG=none ==========
henrik.lundin@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
lgtm
aleloi@webrtc.org changed reviewers: + phoglund@webrtc.org
Description was changed from ========== A quick fix of a pyplot plotting issue in rtp analyzer. BUG=none ========== to ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. BUG=none ==========
phoglund@, could you please take a look?
Rubberstamp LGTM
lgtm
Description was changed from ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. BUG=none ========== to ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. NOTRY=True BUG=none ==========
The CQ bit was checked by aleloi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. NOTRY=True BUG=none ========== to ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. NOTRY=True BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. NOTRY=True BUG=none ========== to ========== During a fix of an unrelated issue, a bug was introduced in the rtp analyzer tool: when the number of data points was divisible by RTPStatitstics.PLOT_RESOLUTION_MS (which is 50), pyplot.plot was called with arrays of different lengths. One of the arrays could be one element larger. This change trims the potentially longer array to the size of the smaller one. NOTRY=True BUG=none Committed: https://crrev.com/553024ab34e7307046388d20c29e9f9a8177aa0a Cr-Commit-Position: refs/heads/master@{#14657} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/553024ab34e7307046388d20c29e9f9a8177aa0a Cr-Commit-Position: refs/heads/master@{#14657} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
