Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2357583002: Remove unnecessary interface TelephoneEventHandler (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary interface TelephoneEventHandler. BUG=webrtc:2795 Committed: https://crrev.com/2beb42983ca24e1326a9a7f2c06b3ad740eea2c3 Cr-Commit-Position: refs/heads/master@{#14346}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -65 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 2 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 1 chunk +2 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
the sun
4 years, 3 months ago (2016-09-20 10:35:19 UTC) #2
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-21 07:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357583002/40001
4 years, 3 months ago (2016-09-21 12:36:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16950)
4 years, 3 months ago (2016-09-21 12:54:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357583002/40001
4 years, 3 months ago (2016-09-22 08:13:25 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 08:46:07 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2beb42983ca24e1326a9a7f2c06b3ad740eea2c3 Cr-Commit-Position: refs/heads/master@{#14346}
4 years, 3 months ago (2016-09-22 08:46:13 UTC) #15
danilchap
4 years, 3 months ago (2016-09-22 10:36:11 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2362673002/ by danilchap@webrtc.org.

The reason for reverting is: breaks downstream code.

Powered by Google App Engine
This is Rietveld 408576698