Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2357213002: Fix deadlock issue in CameraCapturer.stopCapture. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix deadlock issue in CameraCapturer.stopCapture. BUG=webrtc:6404 NOTRY=True Committed: https://crrev.com/28d5bc68c353c46d43faf0a875dea77863852691 Cr-Commit-Position: refs/heads/master@{#14333}

Patch Set 1 #

Patch Set 2 : New approach. #

Total comments: 2

Patch Set 3 : Changes according to magjed's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -73 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera1Session.java View 1 2 2 chunks +8 lines, -34 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 2 2 chunks +8 lines, -34 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
sakal
PTAL
4 years, 2 months ago (2016-09-21 13:28:02 UTC) #5
magjed_webrtc
lgtm https://codereview.webrtc.org/2357213002/diff/20001/webrtc/api/android/java/src/org/webrtc/Camera1Session.java File webrtc/api/android/java/src/org/webrtc/Camera1Session.java (right): https://codereview.webrtc.org/2357213002/diff/20001/webrtc/api/android/java/src/org/webrtc/Camera1Session.java#newcode185 webrtc/api/android/java/src/org/webrtc/Camera1Session.java:185: final long stopStartTime = System.nanoTime(); Move this inside ...
4 years, 2 months ago (2016-09-21 14:19:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357213002/40001
4 years, 2 months ago (2016-09-21 14:21:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357213002/40001
4 years, 2 months ago (2016-09-21 14:41:25 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-21 14:44:53 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-21 14:45:03 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28d5bc68c353c46d43faf0a875dea77863852691
Cr-Commit-Position: refs/heads/master@{#14333}

Powered by Google App Engine
This is Rietveld 408576698