Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2356563002: Log supported camera preview resolutions. (Closed)

Created:
4 years, 3 months ago by AlexG
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sakal
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Log supported camera preview resolutions. BUG=b/29935437 R=sakal@webrtc.org Committed: https://crrev.com/772bd0d40b3b4c18d391c943b92c9c2714a8c027 Cr-Commit-Position: refs/heads/master@{#14336}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Patch Set 3 : Remove non needed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
AlexG
PTAL
4 years, 3 months ago (2016-09-19 21:28:33 UTC) #2
sakal
I think changing the resolution selection logic is the major change here and should be ...
4 years, 3 months ago (2016-09-20 07:38:33 UTC) #4
AlexG
On 2016/09/20 07:38:33, sakal wrote: > I think changing the resolution selection logic is the ...
4 years, 3 months ago (2016-09-20 18:39:06 UTC) #5
sakal
lgtm
4 years, 3 months ago (2016-09-21 08:25:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2356563002/40001
4 years, 3 months ago (2016-09-21 17:14:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-21 19:15:22 UTC) #11
AlexG
4 years, 3 months ago (2016-09-21 19:17:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
772bd0d40b3b4c18d391c943b92c9c2714a8c027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698