Change Camera1Enumerator to create a Camera1Capturer instead of VideoCapturerAndroid.

Change Camera1Enumerator to create a Camera1Capturer instead of VideoCapturerAndroid.

BUG=webrtc:6148
Committed: https://crrev.com/8f741e953c1d712cbf79a96bf2f9afb73542154f
Cr-Commit-Position: refs/heads/master@{#14478}

[sakal, 2016-09-21 08:39:55]

sakal@webrtc.org changed reviewers:
+ glaznev@webrtc.org, magjed@webrtc.org

[sakal, 2016-09-21 08:39:56]

PTAL

[magjed_webrtc, 2016-09-21 11:15:13]

On 2016/09/21 08:39:56, sakal wrote:
> PTAL

Please clarify in the CL description that this change enables a whole new
camera1 implementation which is not as well tested yet, which might be a big
deal for downstream clients.

[AlexG, 2016-09-21 17:24:36]

On 2016/09/21 11:15:13, magjed_webrtc wrote:
> On 2016/09/21 08:39:56, sakal wrote:
> > PTAL
> 
> Please clarify in the CL description that this change enables a whole new
> camera1 implementation which is not as well tested yet, which might be a big
> deal for downstream clients.

Please also add an option for downstream clients to keep using
VideoCapturerAndroid

[sakal, 2016-09-27 09:55:09]

Patchset #2 (id:20001) has been deleted

[sakal, 2016-09-27 09:58:34]

On 2016/09/21 17:24:36, AlexG wrote:
> On 2016/09/21 11:15:13, magjed_webrtc wrote:
> > On 2016/09/21 08:39:56, sakal wrote:
> > > PTAL
> > 
> > Please clarify in the CL description that this change enables a whole new
> > camera1 implementation which is not as well tested yet, which might be a big
> > deal for downstream clients.
> 
> Please also add an option for downstream clients to keep using
> VideoCapturerAndroid

Downstream clients can create VideoCapturerAndroid directly without using
enumerators.

[magjed_webrtc, 2016-09-27 11:26:26]

lgtm

https://codereview.webrtc.org/2356073003/diff/40001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/2356073003/diff/40001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java:41: //
TODO(magjed): This class name is now confusing - rename to Camera1VideoCapturer.
Can you remove my todo, and also comment the deprecation, something like:
// Use Camera1Capturer instead.

[AlexG, 2016-09-27 17:01:39]

lgtm

[sakal, 2016-09-29 11:09:03]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-29 11:09:14]

The CQ bit was unchecked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-29 11:09:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-09-29 11:12:19]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-29 11:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2356073003/#ps60001 (title:
"Comments.")

[commit-bot: I haz the power, 2016-09-29 11:12:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 11:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:14:08]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14762)

[sakal, 2016-09-29 11:31:39]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-29 11:31:39]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2356073003/#ps80001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-09-29 11:31:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 11:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:33:33]

Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13349)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/18604)

[sakal, 2016-09-30 12:27:30]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-30 12:27:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-09-30 12:58:31]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-30 12:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2356073003/#ps100001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-09-30 12:58:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-30 14:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 14:26:04]

Try jobs failed on following builders:
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)

[sakal, 2016-10-03 07:32:42]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-10-03 07:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 09:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 09:33:27]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sakal, 2016-10-03 14:57:36]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-10-03 14:57:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 15:06:01]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-03 15:06:13]

Description was changed from

==========
Change Camera1Enumerator to create a Camera1Capturer instead of
VideoCapturerAndroid.

BUG=webrtc:6148
==========

to

==========
Change Camera1Enumerator to create a Camera1Capturer instead of
VideoCapturerAndroid.

BUG=webrtc:6148

Committed: https://crrev.com/8f741e953c1d712cbf79a96bf2f9afb73542154f
Cr-Commit-Position: refs/heads/master@{#14478}
==========

[commit-bot: I haz the power, 2016-10-03 15:06:14]

Patchset 5 (id:??) landed as
https://crrev.com/8f741e953c1d712cbf79a96bf2f9afb73542154f
Cr-Commit-Position: refs/heads/master@{#14478}