Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/audio_coding/neteq/include/neteq.h

Issue 2355503002: Stopped using the NetEqDecoder enum internally in NetEq. (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/neteq/decoder_database.cc ('K') | « webrtc/modules/audio_coding/neteq/delay_manager.cc ('k') | webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/include/neteq.h
diff --git a/webrtc/modules/audio_coding/neteq/include/neteq.h b/webrtc/modules/audio_coding/neteq/include/neteq.h
index c07143c062020dd9fd02d46843cf550fd82168e4..0df50ced72df5511e35f7c4a102c2c8962053446 100644
--- a/webrtc/modules/audio_coding/neteq/include/neteq.h
+++ b/webrtc/modules/audio_coding/neteq/include/neteq.h
@@ -261,7 +261,8 @@ class NetEq {
// Returns the decoder format for the given payload type. Returns null if no
hlundin-webrtc 2016/09/22 12:36:16 null -> empty?
ossu 2016/09/22 14:43:06 Yes! Good catch!
// such payload type was registered, or if it was registered without
// providing an SdpAudioFormat.
- virtual const SdpAudioFormat* GetDecoderFormat(int payload_type) const = 0;
+ virtual rtc::Optional<SdpAudioFormat> GetDecoderFormat(
+ int payload_type) const = 0;
// Not implemented.
virtual int SetTargetNumberOfChannels() = 0;
« webrtc/modules/audio_coding/neteq/decoder_database.cc ('K') | « webrtc/modules/audio_coding/neteq/delay_manager.cc ('k') | webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698