Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2355393005: Adds audio session status to logs for each valid audio route change on iOS (Closed)

Created:
4 years, 2 months ago by henrika_webrtc
Modified:
4 years, 2 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tkchin_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds audio session status to logs for each valid audio route change on iOS BUG=b/30944297 NOTRY=TRUE Committed: https://crrev.com/051d15156967bf5702b15789b62c98c97ef58577 Cr-Commit-Position: refs/heads/master@{#14355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
henrika_webrtc
Simple but useful: )> [018:405] [34335] (RTCLogging.mm:31): (audio_device_ios.mm:494 HandleValidRouteChange): RTCAudioSession: { category: AVAudioSessionCategoryPlayAndRecord categoryOptions: 12 ...
4 years, 2 months ago (2016-09-22 14:45:29 UTC) #3
henrika_webrtc
Now added to the logs at each valid route change.
4 years, 2 months ago (2016-09-22 14:46:15 UTC) #4
Chuck
lgtm
4 years, 2 months ago (2016-09-22 15:04:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2355393005/1
4 years, 2 months ago (2016-09-22 15:08:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2355393005/1
4 years, 2 months ago (2016-09-22 15:38:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 15:48:08 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 15:48:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/051d15156967bf5702b15789b62c98c97ef58577
Cr-Commit-Position: refs/heads/master@{#14355}

Powered by Google App Engine
This is Rietveld 408576698