Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2354883002: Add new Camera2Enumerator.isSupported with Context parameter. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new Camera2Enumerator.isSupported with Context parameter. The old method is marked deprecated and will be removed soon. The new method checks if all cameras on the device support better than legacy implementation of the camera2 API. BUG=webrtc:6390 Committed: https://crrev.com/1c6d3f7eae87cf31eabc3c9389c375170097cad4 Cr-Commit-Position: refs/heads/master@{#14350}

Patch Set 1 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/examples/androidapp/res/values/strings.xml View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-20 10:13:19 UTC) #2
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-20 11:29:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354883002/20001
4 years, 3 months ago (2016-09-20 11:37:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-20 13:38:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354883002/20001
4 years, 3 months ago (2016-09-22 11:19:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-22 12:52:11 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:52:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c6d3f7eae87cf31eabc3c9389c375170097cad4
Cr-Commit-Position: refs/heads/master@{#14350}

Powered by Google App Engine
This is Rietveld 408576698