Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2354723002: Fixing heap read overflow when "sctp-port" is in a video description. (Closed)

Created:
4 years, 3 months ago by Taylor Brandstetter
Modified:
4 years, 2 months ago
Reviewers:
skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing heap read overflow when "sctp-port" is in a video description. This added an SCTP codec, which is later re-interpreted as a video codec. We shouldn't be adding codecs that don't match the type of the media description. BUG=chromium:648062 Committed: https://crrev.com/7e146cb97e27644691a8017fe252dfc184c03808 Cr-Commit-Position: refs/heads/master@{#14421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
skvlad
lgtm
4 years, 3 months ago (2016-09-20 02:38:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354723002/1
4 years, 2 months ago (2016-09-27 21:28:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-27 23:29:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354723002/1
4 years, 2 months ago (2016-09-28 16:52:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 17:04:38 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 17:04:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e146cb97e27644691a8017fe252dfc184c03808
Cr-Commit-Position: refs/heads/master@{#14421}

Powered by Google App Engine
This is Rietveld 408576698