RTCPReceiver store cname as std::string.

RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true

Committed: https://crrev.com/95321246593bc5fa1f0d60fff6edba0d2fb13342
Cr-Commit-Position: refs/heads/master@{#14399}

[danilchap, 2016-09-26 07:54:45]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2016-09-26 15:43:32]

lg

https://codereview.webrtc.org/2354333004/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (left):

https://codereview.webrtc.org/2354333004/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:130:
RTCPUtility::RTCPCnameInformation* CreateCnameInformation(
Is RTCPnameInformation still used in this CL? Maybe you should remove the struct
from rtcp_utility.h.

[danilchap, 2016-09-26 16:53:13]

On 2016/09/26 15:43:32, philipel wrote:
> lg
> 
>
https://codereview.webrtc.org/2354333004/diff/20001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (left):
> 
>
https://codereview.webrtc.org/2354333004/diff/20001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:130:
> RTCPUtility::RTCPCnameInformation* CreateCnameInformation(
> Is RTCPnameInformation still used in this CL? Maybe you should remove the
struct
> from rtcp_utility.h.

No, that is the last use of the RTCPUtility::RTCPCnameInformation in webrtc
code.
while it can be removed from rtcp_utility.h, I have a more ambitious goal:
removing rtcp_utility.h
I'm not sure if it is better to remove parts of the rtcp_utility.h or postpone
and remove the full file.

[philipel, 2016-09-27 07:57:47]

In that case I think its better to remove the struct from the .h file as well
(to make it clear that the intention of this CL was to remove/stop using it) and
then to update the description with something like "removing rtcp_utility.h part
1"

[danilchap, 2016-09-27 08:06:27]

Description was changed from

==========
RTCPReceiver store cname as std::string.

BUG=webrtc:5565
==========

to

==========
RTCPReceiver store cname as std::string.
Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
==========

[danilchap, 2016-09-27 08:07:57]

On 2016/09/27 07:57:47, philipel wrote:
> In that case I think its better to remove the struct from the .h file as well
> (to make it clear that the intention of this CL was to remove/stop using it)
and
> then to update the description with something like "removing rtcp_utility.h
part
> 1"

structure removed, description updated (with what was done, but not with future
plans)

[philipel, 2016-09-27 08:18:03]

lgtm, but could you explain why you don't want to update the description with
your long term goal?

[danilchap, 2016-09-27 08:27:38]

Description was changed from

==========
RTCPReceiver store cname as std::string.
Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
==========

to

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
==========

[danilchap, 2016-09-27 08:31:58]

On 2016/09/27 08:18:03, philipel wrote:
> lgtm, but could you explain why you don't want to update the description with
> your long term goal?

I see CL description (that would be stored together with the commit in history)
as what had happen in this exact CL. (thanks to your question I added
motivation.)

Plans might change, postpone for long time and might not be directly related to
the change.
They are better to write in the attached bug or a design doc.

The main goal of this CL is to simplify cname storing.

[philipel, 2016-09-27 08:39:12]

On 2016/09/27 08:31:58, danilchap wrote:
> On 2016/09/27 08:18:03, philipel wrote:
> > lgtm, but could you explain why you don't want to update the description
with
> > your long term goal?
> 
> I see CL description (that would be stored together with the commit in
history)
> as what had happen in this exact CL. (thanks to your question I added
> motivation.)
> 
> Plans might change, postpone for long time and might not be directly related
to
> the change.
> They are better to write in the attached bug or a design doc.
> 
> The main goal of this CL is to simplify cname storing.

That makes perfect sense :)

[danilchap, 2016-09-27 10:25:19]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-09-27 10:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-27 12:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:26:02]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[danilchap, 2016-09-27 13:56:33]

Description was changed from

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
==========

to

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true
==========

[danilchap, 2016-09-27 13:56:40]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-09-27 13:56:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-27 14:05:37]

Description was changed from

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true
==========

to

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-27 14:05:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 14:05:46]

Description was changed from

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true
==========

to

==========
RTCPReceiver store cname as std::string.
simplifying cname management.

Remove RTCPUtility::RTCPCnameInformation
since it was last use of the structure.

BUG=webrtc:5565
NOTRY=true

Committed: https://crrev.com/95321246593bc5fa1f0d60fff6edba0d2fb13342
Cr-Commit-Position: refs/heads/master@{#14399}
==========

[commit-bot: I haz the power, 2016-09-27 14:05:47]

Patchset 3 (id:??) landed as
https://crrev.com/95321246593bc5fa1f0d60fff6edba0d2fb13342
Cr-Commit-Position: refs/heads/master@{#14399}