Relanding of "Adding BitrateController to audio network adaptor."

Relanding of "Adding BitrateController to audio network adaptor."

Adding BitrateController to audio network adaptor was first landed in https://codereview.webrtc.org/2334613002/ but reverted in https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
Committed: https://crrev.com/4aec1d4437a3944270c4d9de68b7a1c74a9f1185
Cr-Commit-Position: refs/heads/master@{#14343}

[minyue-webrtc, 2016-09-21 12:54:45]

Description was changed from

==========
Relanding of "Adding BitrateController to audio network adaptor. (patchset #7
id:140001 of https://codereview.webrtc.org/2334613002/ )"

This reverts commit 33b96b3588fe47ba0610ec0c2e3501a0a94298ce.

BUG=
==========

to

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in 

and reverted in https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

[minyue-webrtc, 2016-09-21 12:54:45]

minyue@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, michaelt@webrtc.org

[minyue-webrtc, 2016-09-21 12:55:17]

Description was changed from

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in 

and reverted in https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

to

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in
https://codereview.webrtc.org/2334613002/ but reverted in
https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

[minyue-webrtc, 2016-09-21 12:57:03]

Hi Michael and Henrik,

I try to reland BitrateController with this CL. PTAL.

A follow-up to this would be to add "namespace audio_network_adaptor" for all
classes in this module.

[hlundin-webrtc, 2016-09-21 15:19:30]

LGTM with one nit.

https://codereview.webrtc.org/2353293002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc
(right):

https://codereview.webrtc.org/2353293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc:37:
// AnaBitrateControllerTest in
The ones in modules/bitrate_controller/bitrate_controller_unittest.cc are not
called AnaBitrateControllerTest, right?

[minyue-webrtc, 2016-09-21 18:49:22]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 18:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-21 20:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:49:55]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[minyue-webrtc, 2016-09-22 05:04:48]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-22 05:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2353293002/#ps40001 (title:
"fixing a nit")

[commit-bot: I haz the power, 2016-09-22 05:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-22 05:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 05:07:01]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8615)

[minyue-webrtc, 2016-09-22 05:18:48]

https://codereview.webrtc.org/2353293002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc
(right):

https://codereview.webrtc.org/2353293002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc:37:
// AnaBitrateControllerTest in
On 2016/09/21 15:19:29, hlundin-webrtc wrote:
> The ones in modules/bitrate_controller/bitrate_controller_unittest.cc are not
> called AnaBitrateControllerTest, right?

Thanks, that is right! I tried to change the name to BitrateControllerTest to
see if the namespace would allow. but it didn't, and then I replace the name
again and therefore made this mistake.

[minyue-webrtc, 2016-09-22 05:18:53]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-22 05:18:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2353293002/#ps60001 (title:
"rebasing")

[commit-bot: I haz the power, 2016-09-22 05:19:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-22 06:01:28]

Description was changed from

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in
https://codereview.webrtc.org/2334613002/ but reverted in
https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

to

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in
https://codereview.webrtc.org/2334613002/ but reverted in
https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

[commit-bot: I haz the power, 2016-09-22 06:01:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 06:01:38]

Description was changed from

==========
Relanding of "Adding BitrateController to audio network adaptor." 

Adding BitrateController to audio network adaptor was first landed in
https://codereview.webrtc.org/2334613002/ but reverted in
https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303
==========

to

==========
Relanding of "Adding BitrateController to audio network adaptor."

Adding BitrateController to audio network adaptor was first landed in
https://codereview.webrtc.org/2334613002/ but reverted in
https://codereview.webrtc.org/2352223002/ due to ODR violation.

This CL tries to use namespace trick to solve the ODR problem.

BUG=webrtc:6303

Committed: https://crrev.com/4aec1d4437a3944270c4d9de68b7a1c74a9f1185
Cr-Commit-Position: refs/heads/master@{#14343}
==========

[commit-bot: I haz the power, 2016-09-22 06:01:39]

Patchset 4 (id:??) landed as
https://crrev.com/4aec1d4437a3944270c4d9de68b7a1c74a9f1185
Cr-Commit-Position: refs/heads/master@{#14343}