Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2353163003: Revert of Release camera statistics after switching camera on CameraCapturer. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Release camera statistics after switching camera on CameraCapturer. (patchset #1 id:1 of https://codereview.webrtc.org/2353263002/ ) Reason for revert: Breaks bots. Original issue's description: > Release camera statistics after switching camera on CameraCapturer. > > BUG=webrtc:6397 > TBR=magjed@webrtc.org > NOTRY=True > > Committed: https://crrev.com/d5e9237b303e5fe253dc6530fbcf939921f4eaed > Cr-Commit-Position: refs/heads/master@{#14323} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6397 Committed: https://crrev.com/ad5d65845f5c859d0564811a4eea68e1efdb8450 Cr-Commit-Position: refs/heads/master@{#14324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sakal
Created Revert of Release camera statistics after switching camera on CameraCapturer.
4 years, 3 months ago (2016-09-21 10:50:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2353163003/1
4 years, 3 months ago (2016-09-21 10:50:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 10:51:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ad5d65845f5c859d0564811a4eea68e1efdb8450 Cr-Commit-Position: refs/heads/master@{#14324}
4 years, 3 months ago (2016-09-21 10:51:23 UTC) #6
sakal
4 years, 3 months ago (2016-09-21 11:30:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2357893002/ by sakal@webrtc.org.

The reason for reverting is: Fix bugs causing the new code to fail..

Powered by Google App Engine
This is Rietveld 408576698