Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2353043003: Delete unused class FakeScreenCapturerFactory. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, danilchap
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class FakeScreenCapturerFactory. Last use of the header file probably deleted in cl https://codereview.webrtc.org/1903393004 BUG=None Committed: https://crrev.com/2a27b0a478f008ad17b29bb70e01bcec6c7d709d Cr-Commit-Position: refs/heads/master@{#14370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/media/base/fakescreencapturerfactory.h View 1 chunk +0 lines, -61 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
nisse-webrtc
The class was added to libjingle August 2014, moved around but otherwise unchanged since then. ...
4 years, 3 months ago (2016-09-21 08:22:43 UTC) #2
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-21 08:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2353043003/1
4 years, 3 months ago (2016-09-21 08:49:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16938)
4 years, 3 months ago (2016-09-21 08:59:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2353043003/1
4 years, 3 months ago (2016-09-23 07:06:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/13130)
4 years, 3 months ago (2016-09-23 07:10:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2353043003/1
4 years, 3 months ago (2016-09-23 11:38:10 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 11:42:49 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 11:42:57 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2a27b0a478f008ad17b29bb70e01bcec6c7d709d
Cr-Commit-Position: refs/heads/master@{#14370}

Powered by Google App Engine
This is Rietveld 408576698