Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection (Closed)
Patch Set: Moved the constructor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_quality_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index dd8513fa00c2339c552c63b63cb48984c5fc4664..d138893ba4cc293155b8daa7595c0f3eb715ef61 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -60,8 +60,7 @@ class VideoSendStreamTest : public test::CallTest {
};
TEST_F(VideoSendStreamTest, CanStartStartedStream) {
- Call::Config call_config;
- CreateSenderCall(call_config);
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -72,8 +71,7 @@ TEST_F(VideoSendStreamTest, CanStartStartedStream) {
}
TEST_F(VideoSendStreamTest, CanStopStoppedStream) {
- Call::Config call_config;
- CreateSenderCall(call_config);
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -735,7 +733,7 @@ void VideoSendStreamTest::TestPacketFragmentationSize(VideoFormat format,
}
Call::Config GetSenderCallConfig() override {
- Call::Config config;
+ Call::Config config(&event_log_);
const int kMinBitrateBps = 30000;
config.bitrate_config.min_bitrate_bps = kMinBitrateBps;
return config;
@@ -1438,7 +1436,7 @@ TEST_F(VideoSendStreamTest,
int last_initialized_frame_height_ GUARDED_BY(&crit_);
};
- CreateSenderCall(Call::Config());
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
EncoderObserver encoder;
@@ -1494,7 +1492,7 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) {
int start_bitrate_kbps_ GUARDED_BY(crit_);
};
- CreateSenderCall(Call::Config());
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -1575,7 +1573,7 @@ TEST_F(VideoSendStreamTest, VideoSendStreamStopSetEncoderRateToZero) {
int bitrate_kbps_ GUARDED_BY(crit_);
};
- CreateSenderCall(Call::Config());
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -1630,7 +1628,7 @@ TEST_F(VideoSendStreamTest, CapturesTextureAndVideoFrames) {
};
// Initialize send stream.
- CreateSenderCall(Call::Config());
+ CreateSenderCall(Call::Config(&event_log_));
test::NullTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -2269,7 +2267,7 @@ TEST_F(VideoSendStreamTest, ReconfigureBitratesSetsEncoderBitratesCorrectly) {
}
Call::Config GetSenderCallConfig() override {
- Call::Config config;
+ Call::Config config(&event_log_);
config.bitrate_config.min_bitrate_bps = kMinBitrateKbps * 1000;
config.bitrate_config.start_bitrate_bps = kStartBitrateKbps * 1000;
config.bitrate_config.max_bitrate_bps = kMaxBitrateKbps * 1000;
« no previous file with comments | « webrtc/video/video_quality_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698