Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: webrtc/api/peerconnection.h

Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection (Closed)
Patch Set: Moved the constructor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/mediacontroller.cc ('k') | webrtc/api/peerconnection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnection.h
diff --git a/webrtc/api/peerconnection.h b/webrtc/api/peerconnection.h
index 3087160e4329aad293f4ce272d7b5b426f5b17ff..f5b0af8c42caa0dd224d8ee111313af8350b5cc9 100644
--- a/webrtc/api/peerconnection.h
+++ b/webrtc/api/peerconnection.h
@@ -29,6 +29,7 @@ namespace webrtc {
class MediaStreamObserver;
class VideoRtpReceiver;
+class RtcEventLog;
// Populates |session_options| from |rtc_options|, and returns true if options
// are valid.
@@ -392,6 +393,8 @@ class PeerConnection : public PeerConnectionInterface,
IceGatheringState ice_gathering_state_;
std::unique_ptr<cricket::PortAllocator> port_allocator_;
+ // The EventLog needs to outlive the media controller.
+ std::unique_ptr<RtcEventLog> event_log_;
std::unique_ptr<MediaControllerInterface> media_controller_;
// One PeerConnection has only one RTCP CNAME.
@@ -426,7 +429,6 @@ class PeerConnection : public PeerConnectionInterface,
std::vector<
rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>>
receivers_;
-
std::unique_ptr<WebRtcSession> session_;
std::unique_ptr<StatsCollector> stats_;
rtc::scoped_refptr<RTCStatsCollector> stats_collector_;
« no previous file with comments | « webrtc/api/mediacontroller.cc ('k') | webrtc/api/peerconnection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698