Refactoring: move ownership of RtcEventLog from Call to PeerConnection

webrtc/test/call_test.h

Index: webrtc/test/call_test.h
diff --git a/webrtc/test/call_test.h b/webrtc/test/call_test.h
index 29bdbf2bcf656f90eeac2d6a77088e1a4e47b2cd..ff847826020bde4e71df3832e116a729cd673292 100644
--- a/webrtc/test/call_test.h
+++ b/webrtc/test/call_test.h
@@ -14,6 +14,7 @@
 #include <vector>
 
 #include "webrtc/call.h"
+#include "webrtc/logging/rtc_event_log/rtc_event_log.h"
 #include "webrtc/test/encoder_settings.h"
 #include "webrtc/test/fake_audio_device.h"
 #include "webrtc/test/fake_decoder.h"
@@ -90,6 +91,7 @@ class CallTest : public ::testing::Test {
 
   Clock* const clock_;
 
+  webrtc::RtcEventLogNullImpl event_log_;
   std::unique_ptr<Call> sender_call_;
   std::unique_ptr<PacketTransport> send_transport_;
   VideoSendStream::Config video_send_config_;
@@ -179,6 +181,8 @@ class BaseTest : public RtpRtcpObserver {
 
   virtual void OnFrameGeneratorCapturerCreated(
       FrameGeneratorCapturer* frame_generator_capturer);
+
+  webrtc::RtcEventLogNullImpl event_log_;

[stefan-webrtc, 2016/10/05 07:35:22]

Seems a bit odd that we need this both in BaseTest and CallTest. I think the
right thing to do would be to remove this line and change CallTest so that it
passes an RtcEventLog* into GetSenderCallConfig() and GetReceiverCallConfig().
WDYT?

An alternative would be to have CallTest always change the Call::Configs it gets
back and assign it the null event_log_. Maybe it could do that only if the
returned Call:Config has a nullptr assigned to its event_log? That'd remove all
the boilerplate you had to add to tests inheriting from BaseTest.

[skvlad, 2016/10/06 01:31:38]

This would make the tests even more tricky to follow, as you need to be
constantly aware that the null log is substituted for you in some tests but not
in others. It will also make it impossible to require an RtcEventLog in the
config constructor.

[stefan-webrtc, 2016/10/06 08:53:14]

Agree, it's far from ideal.

I'm still not sure about having this event_log_ in both CallTest and BaseTest,
but I think that's an artifact of some tests only use CallTest while others are
based on BaseTest. I think ideally all those tests should be based on
BaseTest...

WDYT of passing event_log into GetSenderCallConfig() and GetReceiverCallConfig()
instead of having it as a member in BaseTest? I don't feel very strongly about
it, so I'm fine as is too.

 };
 
 class SendTest : public BaseTest {