Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: webrtc/call/rtc_event_log.cc

Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection (Closed)
Patch Set: Moved DEPS entry to subdirectory Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/rtc_event_log.cc
diff --git a/webrtc/call/rtc_event_log.cc b/webrtc/call/rtc_event_log.cc
index c022296730409ca236b25403da9e602698a95cdc..db81572f3d3b6d3758e613e9d4e902cbd5bd2977 100644
--- a/webrtc/call/rtc_event_log.cc
+++ b/webrtc/call/rtc_event_log.cc
@@ -121,6 +121,7 @@ rtclog::MediaType ConvertMediaType(MediaType media_type) {
// sent packets because they also contain received packets.
static const int kEventsPerSecond = 1000;
static const int kControlMessagesPerSecond = 10;
+
} // namespace
// RtcEventLogImpl member functions.
@@ -420,26 +421,13 @@ bool RtcEventLog::ParseRtcEventLog(const std::string& file_name,
#endif // ENABLE_RTC_EVENT_LOG
-bool RtcEventLogNullImpl::StartLogging(rtc::PlatformFile platform_file,
- int64_t max_size_bytes) {
- // The platform_file is open and needs to be closed.
- if (!rtc::ClosePlatformFile(platform_file)) {
- LOG(LS_ERROR) << "Can't close file.";
- }
- return false;
-}
-
// RtcEventLog member functions.
std::unique_ptr<RtcEventLog> RtcEventLog::Create(const Clock* clock) {
#ifdef ENABLE_RTC_EVENT_LOG
return std::unique_ptr<RtcEventLog>(new RtcEventLogImpl(clock));
#else
- return std::unique_ptr<RtcEventLog>(new RtcEventLogNullImpl());
+ return std::unique_ptr<RtcEventLog>();
#endif // ENABLE_RTC_EVENT_LOG
}
-std::unique_ptr<RtcEventLog> RtcEventLog::CreateNull() {
- return std::unique_ptr<RtcEventLog>(new RtcEventLogNullImpl());
-}
-
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698