webrtc/tools/event_log_visualizer/analyzer.cc - Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection (Closed)

Patch Set: Make TSan happy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/tools/event_log_visualizer/analyzer.cc

diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc

index 260975b4b530f96bfff06f3f0b3eeff66e7e1526..75f3aa6ea6e1e3b6ddcb184f1b1f03907c245daa 100644

--- a/webrtc/tools/event_log_visualizer/analyzer.cc

+++ b/webrtc/tools/event_log_visualizer/analyzer.cc

@@ -952,8 +952,7 @@ void EventLogAnalyzer::CreateBweSimulationGraph(Plot* plot) {

SimulatedClock clock(0);

BitrateObserver observer;

- RtcEventLogNullImpl null_event_log;

- CongestionController cc(&clock, &observer, &observer, &null_event_log);

+ CongestionController cc(&clock, &observer, &observer, nullptr);

// TODO(holmer): Log the call config and use that here instead.

static const uint32_t kDefaultStartBitrateBps = 300000;

cc.SetBweBitrates(0, kDefaultStartBitrateBps, -1);