webrtc/api/DEPS - Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/api/DEPS

Issue 2353033005: Refactoring: move ownership of RtcEventLog from Call to PeerConnection (Closed)

Patch Set: Moved DEPS entry to subdirectory Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+third_party/libyuv",	2 "+third_party/libyuv",

3 "+webrtc/base",	3 "+webrtc/base",

4 "+webrtc/common_video",	4 "+webrtc/common_video",

5 "+webrtc/media",	5 "+webrtc/media",

6 "+webrtc/p2p",	6 "+webrtc/p2p",

7 "+webrtc/pc",	7 "+webrtc/pc",

8 "+webrtc/modules/audio_device",	8 "+webrtc/modules/audio_device",

9 "+webrtc/modules/rtp_rtcp",	9 "+webrtc/modules/rtp_rtcp",

10 "+webrtc/modules/video_coding",	10 "+webrtc/modules/video_coding",

11 "+webrtc/modules/video_render",	11 "+webrtc/modules/video_render",

12 "+webrtc/system_wrappers",	12 "+webrtc/system_wrappers",

13 ]	13 ]

14	14

15 specific_include_rules = {	15 specific_include_rules = {

16 "androidtestinitializer\.cc": [	16 "androidtestinitializer\.cc": [

17 "+base/android", # Allowed only for Android tests.	17 "+base/android", # Allowed only for Android tests.

18 "+webrtc/voice_engine",	18 "+webrtc/voice_engine",

19 ],	19 ],

	20 "peerconnection\.cc": [

	21 "+webrtc/call/rtc_event_log.h",
	kjellander_webrtc 2016/10/04 13:22:30 I think "+webrtc/call" should be allowed for all s I think "+webrtc/call" should be allowed for all sources in webrtc/api. I'm not sure why the special cases exist for the entries below. Maybe it's because they're undesired dependencies... either way webrtc/call is a supported API that shouldn't need to be limited. skvlad 2016/10/06 01:31:37 Done. Show quoted text On 2016/10/04 13:22:30, kjellander_webrtc wrote: > I think "+webrtc/call" should be allowed for all sources in webrtc/api. > I'm not sure why the special cases exist for the entries below. Maybe it's > because they're undesired dependencies... either way webrtc/call is a supported > API that shouldn't need to be limited. Done.
	22 ],

20 "peerconnection_jni\.cc": [	23 "peerconnection_jni\.cc": [

21 "+webrtc/voice_engine",	24 "+webrtc/voice_engine",

22 ],	25 ],

23 "peerconnectionfactory.\cc": [	26 "peerconnectionfactory\.cc": [

24 "+webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h",	27 "+webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h",

25 ]	28 ],

26 }	29 }

OLD	NEW

« no previous file with comments | « no previous file | webrtc/api/mediacontroller.h » ('j') | webrtc/call/call.cc » ('J')