Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2352863003: Revert of Allow the DTLS fingerprint verification to occur after the handshake. (Closed)

Created:
4 years, 3 months ago by Taylor Brandstetter
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow the DTLS fingerprint verification to occur after the handshake. (patchset #11 id:200001 of https://codereview.webrtc.org/2163683003/ ) Reason for revert: Broke a downstream user of SSLStreamAdapter. Need to add the new interface (returning error code instead of bool) in a backwards compatible way. Original issue's description: > Allow the DTLS fingerprint verification to occur after the handshake. > > This means the DTLS handshake can make progress while the SDP answer > containing the fingerprint is still in transit. If the signaling path > if significantly slower than the media path, this can have a moderate > impact on call setup time. > > Of course, until the fingerprint is verified no media can be sent. Any > attempted write will result in SR_BLOCK. > > This essentially fulfills the requirements of RFC 4572, Section 6.2: > > Note that when the offer/answer model is being used, it is possible > for a media connection to outrace the answer back to the offerer. > Thus, if the offerer has offered a 'setup:passive' or 'setup:actpass' > role, it MUST (as specified in RFC 4145 [2]) begin listening for an > incoming connection as soon as it sends its offer. However, it MUST > NOT assume that the data transmitted over the TLS connection is valid > until it has received a matching fingerprint in an SDP answer. If > the fingerprint, once it arrives, does not match the client's > certificate, the server endpoint MUST terminate the media connection > with a bad_certificate error, as stated in the previous paragraph. > > BUG=webrtc:6387 > R=mattdr@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/042041bf9585f92e962387c59ca805f1218338f9 > Cr-Commit-Position: refs/heads/master@{#14296} TBR=pthatcher@webrtc.org,mattdr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6387 Committed: https://crrev.com/81f6f4fc56d4bb4c3f43c30a5fed401d39fddcb4 Cr-Commit-Position: refs/heads/master@{#14298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -556 lines) Patch
M webrtc/base/opensslstreamadapter.h View 5 chunks +9 lines, -23 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 26 chunks +99 lines, -157 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 3 chunks +3 lines, -16 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 5 chunks +23 lines, -96 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 6 chunks +7 lines, -54 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 13 chunks +80 lines, -194 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 6 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taylor Brandstetter
Created Revert of Allow the DTLS fingerprint verification to occur after the handshake.
4 years, 3 months ago (2016-09-20 00:20:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352863003/1
4 years, 3 months ago (2016-09-20 00:20:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 00:20:55 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:21:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81f6f4fc56d4bb4c3f43c30a5fed401d39fddcb4
Cr-Commit-Position: refs/heads/master@{#14298}

Powered by Google App Engine
This is Rietveld 408576698