Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2352223002: Revert of Adding BitrateController to audio network adaptor. (Closed)

Created:
4 years, 3 months ago by minyue-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding BitrateController to audio network adaptor. (patchset #7 id:140001 of https://codereview.webrtc.org/2334613002/ ) Reason for revert: ODR violation Original issue's description: > Adding BitrateController to audio network adaptor. > > BUG=webrtc:6303 > > Committed: https://crrev.com/26b039a137be0a8703766f45b546b29323de714f > Cr-Commit-Position: refs/heads/master@{#14293} TBR=michaelt@webrtc.org,henrik.lundin@webrtc.org,krasin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6303 Committed: https://crrev.com/33b96b3588fe47ba0610ec0c2e3501a0a94298ce Cr-Commit-Position: refs/heads/master@{#14327}

Patch Set 1 #

Patch Set 2 : rebasing #

Messages

Total messages: 27 (12 generated)
minyue-webrtc
Created Revert of Adding BitrateController to audio network adaptor.
4 years, 3 months ago (2016-09-20 21:34:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/1
4 years, 3 months ago (2016-09-20 21:34:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-20 23:35:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/1
4 years, 3 months ago (2016-09-21 04:38:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-21 06:38:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/1
4 years, 3 months ago (2016-09-21 06:48:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8564)
4 years, 3 months ago (2016-09-21 06:50:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/230001
4 years, 3 months ago (2016-09-21 07:06:43 UTC) #15
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-21 07:29:14 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/13289)
4 years, 3 months ago (2016-09-21 08:21:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/230001
4 years, 3 months ago (2016-09-21 08:47:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-21 09:07:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352223002/230001
4 years, 3 months ago (2016-09-21 09:17:18 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 3 months ago (2016-09-21 11:30:22 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 11:30:32 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33b96b3588fe47ba0610ec0c2e3501a0a94298ce
Cr-Commit-Position: refs/heads/master@{#14327}

Powered by Google App Engine
This is Rietveld 408576698