Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2352093002: ProbeController: Limit max probing bitrate (Closed)

Created:
4 years, 3 months ago by Irfan
Modified:
4 years, 2 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ProbeController: Limit max probing bitrate BUG=webrtc:6332 Committed: https://crrev.com/8e6a76194d518c6ed446443797b909d789deb58b Cr-Commit-Position: refs/heads/master@{#14436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/modules/congestion_controller/probe_controller.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Irfan
4 years, 3 months ago (2016-09-20 14:44:18 UTC) #3
philipel
Irfan, remeber to add the webrtc prefix to the bug id, so instead of "BUG=6332" ...
4 years, 3 months ago (2016-09-21 10:56:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352093002/1
4 years, 3 months ago (2016-09-21 17:02:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8596)
4 years, 3 months ago (2016-09-21 17:50:54 UTC) #9
Irfan
Stefan, can you PTAL ?
4 years, 3 months ago (2016-09-22 15:51:42 UTC) #10
Irfan
Stefan, This is waiting on a LGTM
4 years, 2 months ago (2016-09-29 08:36:27 UTC) #11
stefan-webrtc
lgtm
4 years, 2 months ago (2016-09-29 10:00:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352093002/1
4 years, 2 months ago (2016-09-29 10:00:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 12:37:01 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 12:37:13 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8e6a76194d518c6ed446443797b909d789deb58b
Cr-Commit-Position: refs/heads/master@{#14436}

Powered by Google App Engine
This is Rietveld 408576698